feat(report): support multiple presave intervals in flight

[onkwon]

No description provided.

[Copilot]

Pull request overview

This PR extends Pulse’s async reporting flow so that, while a report is “in flight” (-EINPROGRESS), the SDK can periodically presave multiple elapsed live-metrics intervals to the backlog (metricfs) without altering the original in-flight payload.

Changes:

• Update in-flight presave interval logic to anchor against the max of last_report_time and the in-flight report’s window_end, enabling multiple presaves during one in-flight session.
• Add a dedicated live-payload-to-buffer collection path used for in-flight presaves, then reset metrics and advance last_report_time per presaved window.
• Extend metricfs test stubs to expose stored entries by index, and add tests covering multiple presaves during a single in-flight report.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/pulse.c	Implements multi-interval in-flight presave logic, new window bound computation, and presave write path.
include/pulse/pulse_internal.h	Renames the in-flight presave tracking flag in the internal report context.
tests/src/pulse_report_test.cpp	Adds a test validating multiple presaves while a report remains in progress; minor assertion refactor.
tests/stubs/metricfs_stub.h	Adds APIs to read stubbed backlog entries by index for tests.
tests/stubs/metricfs_stub.c	Implements indexed accessors for stored backlog entries in the metricfs stub.

Comments suppressed due to low confidence (1)

src/pulse.c:426

• When an in-flight LIVE report has already been presaved to backlog, abort_flight() saves the original in-flight payload via metricfs_write(), which appends it after the newer presaved entries. This produces backlog entries out of chronological order (older window written after newer windows), which can violate the documented “oldest-first” replay expectation. Consider preserving the original in-flight payload separately and ensuring it is enqueued ahead of newer presaves (or otherwise maintaining chronological ordering) when an abort occurs.

	if (m.live_presave_during_flight) {
		/* Preserve the original in-flight payload as-is. This keeps
		 * its LIVE reason and may append it after newer backlog data.
		 * A fuller fix should store the original payload separately
		 * from the mutable flight buffer, then rebuild or annotate that
		 * payload with BACKLOG_FAILURE/BACKLOG_CANCEL before enqueueing
		 * it in chronological order, without re-collecting from the
		 * already-reset metrics store. */
		*saved = save_current_flight_to_backlog();
		return PULSE_STATUS_OK;

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.