Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tag strings without a known encoding as ASCII-8BIT. #619

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Tag strings without a known encoding as ASCII-8BIT. #619

wants to merge 3 commits into from

Commits on Jul 8, 2016

  1. Tag strings without a known encoding as ASCII-8BIT. 

    Almost all of the string used inside a git repository are encoding unaware.

This includes things like refnames, commit metadata, path names, and a lot more. The exception is commit messages, which can optionally be tagged with an encoding through a header in the commit metadata. We should only tag strings with an encoding if we know the exact encoding, and otherwise tag them as US-ASCII 8-BIT (binary).
    @arthurschreiber
    arthurschreiber committed Jul 8, 2016
    Configuration menu
    Copy the full SHA
    81743ad View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2016

  1. Prefer String#b over String#force_encoding('ascii-8bit').

    @arthurschreiber
    arthurschreiber committed Aug 18, 2016
    Configuration menu
    Copy the full SHA
    ef77734 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/libgit2/rugged into arthu… 

    …r/binary-all-the-things
    @arthurschreiber
    arthurschreiber committed Aug 18, 2016
    Configuration menu
    Copy the full SHA
    7a9965c View commit details
    Browse the repository at this point in the history