[WIP] Support worktrees in latest libgit2 in -[GTRepository fileURL] #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git_repository_workdir can now return a relative path for a worktree checkout. Need to check if a relative URL is returned and try to create an absolute path using the parent repository.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version of libgit2 with worktree support can return relative paths in git_repository_workdir. This results in
-[GTRepository fileURL]returning an arbitrary URL depending on the current working directory.What seems to work is searching for the parent repository using
git_repository_discover, then combining the result with the relative worktree path and returning that.It might be better to cache the result rather than having to do this every time
fileURLis called. This is a rough PR and I wouldn't be surprised if there's a better way of accomplishing this.