Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add worktree support - Bump version of libgit2 #956

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/backport.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
strategy:
fail-fast: false
matrix:
branch: [ 'release-1.3', 'release-1.2', 'release-1.1', 'release-1.0', 'release-0.28', 'release-0.27' ]
branch: [ 'release-1.6', 'release-1.5', 'release-1.3', 'release-1.2', 'release-1.1', 'release-1.0', 'release-0.28', 'release-0.27' ]

runs-on: ubuntu-20.04

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ jobs:
fail-fast: false
matrix:
libgit2:
- 'v1.5.0'
- 'v1.7.0'
name: Go (system-wide, dynamic)

runs-on: ubuntu-20.04
Expand Down
4 changes: 2 additions & 2 deletions Build_bundled_static.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ package git
#cgo CFLAGS: -DLIBGIT2_STATIC
#include <git2.h>

#if LIBGIT2_VER_MAJOR != 1 || LIBGIT2_VER_MINOR < 5 || LIBGIT2_VER_MINOR > 5
# error "Invalid libgit2 version; this git2go supports libgit2 between v1.5.0 and v1.5.0"
#if LIBGIT2_VER_MAJOR != 1 || LIBGIT2_VER_MINOR < 7 || LIBGIT2_VER_MINOR > 7
# error "Invalid libgit2 version; this git2go supports libgit2 v1.7.x"
#endif
*/
import "C"
4 changes: 2 additions & 2 deletions Build_system_dynamic.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ package git
#cgo CFLAGS: -DLIBGIT2_DYNAMIC
#include <git2.h>

#if LIBGIT2_VER_MAJOR != 1 || LIBGIT2_VER_MINOR < 5 || LIBGIT2_VER_MINOR > 5
# error "Invalid libgit2 version; this git2go supports libgit2 between v1.5.0 and v1.5.0"
#if LIBGIT2_VER_MAJOR != 1 || LIBGIT2_VER_MINOR < 7 || LIBGIT2_VER_MINOR > 7
# error "Invalid libgit2 version; this git2go supports libgit2 v1.7.x"
#endif
*/
import "C"
4 changes: 2 additions & 2 deletions Build_system_static.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ package git
#cgo CFLAGS: -DLIBGIT2_STATIC
#include <git2.h>

#if LIBGIT2_VER_MAJOR != 1 || LIBGIT2_VER_MINOR < 5 || LIBGIT2_VER_MINOR > 5
# error "Invalid libgit2 version; this git2go supports libgit2 between v1.5.0 and v1.5.0"
#if LIBGIT2_VER_MAJOR != 1 || LIBGIT2_VER_MINOR < 7 || LIBGIT2_VER_MINOR > 7
# error "Invalid libgit2 version; this git2go supports libgit2 v1.7.x"
#endif
*/
import "C"
14 changes: 8 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,9 @@ Due to the fact that Go 1.11 module versions have semantic meaning and don't nec

| libgit2 | git2go |
|---------|---------------|
| main | (will be v35) |
| main | (will be v37) |
| 1.7 | v36 |
| 1.6 | v35 |
| 1.5 | v34 |
| 1.3 | v33 |
| 1.2 | v32 |
Expand All @@ -20,13 +22,13 @@ Due to the fact that Go 1.11 module versions have semantic meaning and don't nec
| 0.28 | v28 |
| 0.27 | v27 |

You can import them in your project with the version's major number as a suffix. For example, if you have libgit2 v1.2 installed, you'd import git2go v34 with:
You can import them in your project with the version's major number as a suffix. For example, if you have libgit2 v1.2 installed, you'd import git2go v35 with:

```sh
go get github.com/libgit2/git2go/v34
go get github.com/libgit2/git2go/v36
```
```go
import "github.com/libgit2/git2go/v34"
import "github.com/libgit2/git2go/v36"
```

which will ensure there are no sudden changes to the API.
Expand All @@ -50,7 +52,7 @@ This project wraps the functionality provided by libgit2. If you're using a vers
When linking dynamically against a released version of libgit2, install it via your system's package manager. CGo will take care of finding its pkg-config file and set up the linking. Import via Go modules, e.g. to work against libgit2 v1.2

```go
import "github.com/libgit2/git2go/v34"
import "github.com/libgit2/git2go/v36"
```

### Versioned branch, static linking
Expand Down Expand Up @@ -80,7 +82,7 @@ In order to let Go pass the correct flags to `pkg-config`, `-tags static` needs

One thing to take into account is that since Go expects the `pkg-config` file to be within the same directory where `make install-static` was called, so the `go.mod` file may need to have a [`replace` directive](https://github.com/golang/go/wiki/Modules#when-should-i-use-the-replace-directive) so that the correct setup is achieved. So if `git2go` is checked out at `$GOPATH/src/github.com/libgit2/git2go` and your project at `$GOPATH/src/github.com/my/project`, the `go.mod` file of `github.com/my/project` might need to have a line like

replace github.com/libgit2/git2go/v34 => ../../libgit2/git2go
replace github.com/libgit2/git2go/v36 => ../../libgit2/git2go

Parallelism and network operations
----------------------------------
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
module github.com/libgit2/git2go/v34
module github.com/libgit2/git2go/v36

go 1.13

Expand Down
4 changes: 4 additions & 0 deletions repository.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ type Repository struct {
// Stashes represents the collection of stashes and can be used to
// save, apply and iterate over stash states in this repository.
Stashes StashCollection
// Worktrees represents the collection of worktrees and can be used to
// add, list and remove worktrees for this repository
Worktrees WorktreeCollection

// weak indicates that a repository is a weak pointer and should not be
// freed.
Expand All @@ -52,6 +55,7 @@ func newRepositoryFromC(ptr *C.git_repository) *Repository {
repo.Notes.repo = repo
repo.Tags.repo = repo
repo.Stashes.repo = repo
repo.Worktrees.repo = repo

runtime.SetFinalizer(repo, (*Repository).Free)

Expand Down
2 changes: 1 addition & 1 deletion vendor/libgit2
Submodule libgit2 updated 756 files
271 changes: 271 additions & 0 deletions worktree.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,271 @@
package git

/*
#include <git2.h>
*/
import "C"
import (
"runtime"
"unsafe"
)

type WorktreeCollection struct {
doNotCompare
repo *Repository
}

type Worktree struct {
doNotCompare
ptr *C.git_worktree
}

type AddWorktreeOptions struct {
// Lock the newly created worktree
Lock bool
// Reference to use for the new worktree
Reference *Reference
// CheckoutOptions is used for configuring the checkout for the newly created worktree
CheckoutOptions CheckoutOptions
}

// Add adds a new working tree for the given repository
func (c *WorktreeCollection) Add(name string, path string, options *AddWorktreeOptions) (*Worktree, error) {
cName := C.CString(name)
defer C.free(unsafe.Pointer(cName))

cPath := C.CString(path)
defer C.free(unsafe.Pointer(cPath))

var err error
cOptions := populateAddWorktreeOptions(&C.git_worktree_add_options{}, options, &err)
defer freeAddWorktreeOptions(cOptions)

runtime.LockOSThread()
defer runtime.UnlockOSThread()

var ptr *C.git_worktree
ret := C.git_worktree_add(&ptr, c.repo.ptr, cName, cPath, cOptions)
runtime.KeepAlive(c)
if options != nil && options.Reference != nil {
runtime.KeepAlive(options.Reference)
}

if ret == C.int(ErrorCodeUser) && err != nil {
return nil, err
} else if ret < 0 {
return nil, MakeGitError(ret)
}
return newWorktreeFromC(ptr), nil
}

// List lists names of linked working trees for the given repository
func (c *WorktreeCollection) List() ([]string, error) {
var strC C.git_strarray
defer C.git_strarray_dispose(&strC)

runtime.LockOSThread()
defer runtime.UnlockOSThread()

ret := C.git_worktree_list(&strC, c.repo.ptr)
runtime.KeepAlive(c)
if ret < 0 {
return nil, MakeGitError(ret)
}

w := makeStringsFromCStrings(strC.strings, int(strC.count))
return w, nil
}

// Lookup gets a working tree by its name for the given repository
func (c *WorktreeCollection) Lookup(name string) (*Worktree, error) {
cname := C.CString(name)
defer C.free(unsafe.Pointer(cname))

runtime.LockOSThread()
defer runtime.UnlockOSThread()

var ptr *C.git_worktree
ret := C.git_worktree_lookup(&ptr, c.repo.ptr, cname)
runtime.KeepAlive(c)

if ret < 0 {
return nil, MakeGitError(ret)
} else if ptr == nil {
return nil, nil
}
return newWorktreeFromC(ptr), nil
}

// OpenFromRepository retrieves a worktree for the given repository
func (c *WorktreeCollection) OpenFromRepository() (*Worktree, error) {
runtime.LockOSThread()
defer runtime.UnlockOSThread()

var ptr *C.git_worktree
ret := C.git_worktree_open_from_repository(&ptr, c.repo.ptr)
runtime.KeepAlive(c)

if ret < 0 {
return nil, MakeGitError(ret)
}
return newWorktreeFromC(ptr), nil
}

func newWorktreeFromC(ptr *C.git_worktree) *Worktree {
worktree := &Worktree{ptr: ptr}
runtime.SetFinalizer(worktree, (*Worktree).Free)
return worktree
}

func freeAddWorktreeOptions(cOptions *C.git_worktree_add_options) {
if cOptions == nil {
return
}
freeCheckoutOptions(&cOptions.checkout_options)
}

func populateAddWorktreeOptions(cOptions *C.git_worktree_add_options, options *AddWorktreeOptions, errorTarget *error) *C.git_worktree_add_options {
C.git_worktree_add_options_init(cOptions, C.GIT_WORKTREE_ADD_OPTIONS_VERSION)
if options == nil {
return nil
}

populateCheckoutOptions(&cOptions.checkout_options, &options.CheckoutOptions, errorTarget)
cOptions.lock = cbool(options.Lock)
if options.Reference != nil {
cOptions.ref = options.Reference.ptr
}
return cOptions
}

// Free a previously allocated worktree
func (w *Worktree) Free() {
runtime.SetFinalizer(w, nil)
C.git_worktree_free(w.ptr)
}

// IsLocked checks if the given worktree is locked
func (w *Worktree) IsLocked() (locked bool, reason string, err error) {
buf := C.git_buf{}
defer C.git_buf_dispose(&buf)

runtime.LockOSThread()
defer runtime.UnlockOSThread()

ret := C.git_worktree_is_locked(&buf, w.ptr)
runtime.KeepAlive(w)

if ret < 0 {
return false, "", MakeGitError(ret)
}
return ret != 0, C.GoString(buf.ptr), nil
}

type WorktreePruneFlag uint32

const (
// WorktreePruneValid means prune working tree even if working tree is valid
WorktreePruneValid WorktreePruneFlag = C.GIT_WORKTREE_PRUNE_VALID
// WorktreePruneLocked means prune working tree even if it is locked
WorktreePruneLocked WorktreePruneFlag = C.GIT_WORKTREE_PRUNE_LOCKED
// WorktreePruneWorkingTree means prune checked out working tree
WorktreePruneWorkingTree WorktreePruneFlag = C.GIT_WORKTREE_PRUNE_WORKING_TREE
)

// IsPrunable checks that the worktree is prunable with the given flags
func (w *Worktree) IsPrunable(flags WorktreePruneFlag) (bool, error) {
cOptions := C.git_worktree_prune_options{}
C.git_worktree_prune_options_init(&cOptions, C.GIT_WORKTREE_PRUNE_OPTIONS_VERSION)
cOptions.flags = C.uint32_t(flags)

runtime.LockOSThread()
defer runtime.UnlockOSThread()

ret := C.git_worktree_is_prunable(w.ptr, &cOptions)
runtime.KeepAlive(w)

if ret < 0 {
return false, MakeGitError(ret)
}
return ret != 0, nil
}

// Lock locks the worktree if not already locked
func (w *Worktree) Lock(reason string) error {
var cReason *C.char
if reason != "" {
cReason = C.CString(reason)
defer C.free(unsafe.Pointer(cReason))
}

runtime.LockOSThread()
defer runtime.UnlockOSThread()

ret := C.git_worktree_lock(w.ptr, cReason)
runtime.KeepAlive(w)

if ret < 0 {
return MakeGitError(ret)
}
return nil
}

// Name retrieves the name of the worktree
func (w *Worktree) Name() string {
s := C.GoString(C.git_worktree_name(w.ptr))
runtime.KeepAlive(w)
return s
}

// Path retrieves the path of the worktree
func (w *Worktree) Path() string {
s := C.GoString(C.git_worktree_path(w.ptr))
runtime.KeepAlive(w)
return s
}

// Prune the worktree with the provided flags
func (w *Worktree) Prune(flags WorktreePruneFlag) error {
cOptions := C.git_worktree_prune_options{}
C.git_worktree_prune_options_init(&cOptions, C.GIT_WORKTREE_PRUNE_OPTIONS_VERSION)
cOptions.flags = C.uint32_t(flags)

runtime.LockOSThread()
defer runtime.UnlockOSThread()

ret := C.git_worktree_prune(w.ptr, &cOptions)
runtime.KeepAlive(w)

if ret < 0 {
return MakeGitError(ret)
}
return nil
}

// Unlock a locked worktree
func (w *Worktree) Unlock() (notLocked bool, err error) {
runtime.LockOSThread()
defer runtime.UnlockOSThread()

ret := C.git_worktree_unlock(w.ptr)
runtime.KeepAlive(w)

if ret < 0 {
return false, MakeGitError(ret)
}
return ret != 0, nil
}

// Validate checks if the given worktree is valid
func (w *Worktree) Validate() error {
runtime.LockOSThread()
defer runtime.UnlockOSThread()

ret := C.git_worktree_validate(w.ptr)
runtime.KeepAlive(w)

if ret < 0 {
return MakeGitError(ret)
}
return nil
}
Loading