Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to configure http/s managed transport #870

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Commits on Nov 22, 2021

  1. Add option to configure http/s managed transport

    This change introduces NewRegisterSmartTransportWithOptions() to help
    configure the smart transport with SmartSubtransportOptions. If the
    default smart subtransport client needs to be configured, a newly
    configured smart transport can be registered and used.
    The SmartSubtransportOptions includes CABundle only for now.
    
    This enables creating and using new transport with secrets that can be
    deleted and not shared with subsequent operations.
    
    The http client from httpSmartSubtransport is now shared with the
    underlying httpSmartSubtransportStream, reusing the client and its
    configurations.
    
    It also fixes the error during cloning:
    ```
    unable to clone: Post "http://test-user:***@127.0.0.1:40463/bar/test-reponame/git-upload-pack": io: read/write on closed pipe
    ```
    by using credentials if available and avoiding failure due to
    unauthorized request.
    
    A user of the smart transport who needs to add a CA bundle in the
    http client can do the following to setup the smart transport before
    cloning:
    
    ```
    stOpts := &git2go.SmartSubtransportOptions{CABundle: opts.CAFile}
    rst, err := git2go.NewRegisterSmartTransportWithOptions("https", stOpts)
    if err != nil {
    	return err
    }
    if rst != nil {
    	defer rst.Free()
    }
    ```
    darkowlzz committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    3d4b9b9 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2021

  1. Update SmartServiceActionReceivepack request path

    Similar to SmartServiceActionUploadpack, SmartServiceActionReceivepack
    is not an info endpoint. Fix the path for git-receive-pack.
    darkowlzz committed Nov 28, 2021
    Configuration menu
    Copy the full SHA
    5bd7c33 View commit details
    Browse the repository at this point in the history