Skip to content

Commit

Permalink
CI: catch non-zero %ERRORLEVEL%
Browse files Browse the repository at this point in the history
  • Loading branch information
@mwtoews
mwtoews committed Jun 22, 2024
1 parent 18e8471 commit d84cf1a
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -398,7 +398,9 @@ jobs:
-D BUILD_SHARED_LIBS=ON ^
-D USE_CCACHE=ON ^
..
IF %ERRORLEVEL% NEQ 0 exit
cmake --build . --config ${{ matrix.ci.build_type }} -j 4
IF %ERRORLEVEL% NEQ 0 exit
ccache --show-stats --verbose
- name: Save build cache
Expand Down

3 comments on commit d84cf1a

@pramsey
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It now properly fails on build, rather than incorrectly signally success, but ... it fails on build :) https://github.com/libgeos/geos/actions/runs/9621829751

@pramsey
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, wait, that's an actual MSVC compilation error. On the other hand, the build is now very noisy with these messages....

cl : Command line warning D9025 : overriding '/W3' with '/W4'
[304/746] Building CXX object CMakeFiles\geos.dir\src\operation\overlayng\OverlayEdgeRing.cpp.obj
cl : Command line warning D9025 : overriding '/W3' with '/W4'
[305/746] Building CXX object CMakeFiles\geos.dir\src\operation\overlayng\OverlayLabel.cpp.obj
cl : Command line warning D9025 : overriding '/W3' with '/W4'
[306/746] Building CXX object CMakeFiles\geos.dir\src\operation\overlayng\OverlayLabeller.cpp.obj
cl : Command line warning D9025 : overriding '/W3' with '/W4'

@dbaston
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See note in #1118 about https://cmake.org/cmake/help/latest/policy/CMP0092.html

Please sign in to comment.