Skip to content

Commit

Permalink
Remove dupe tests from RelateNGTest that are now in RelateNGBoundarNo…
Browse files Browse the repository at this point in the history
…deRuleTest
  • Loading branch information
pramsey committed Aug 20, 2024
1 parent c64729c commit adc3348
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 18 deletions.
11 changes: 0 additions & 11 deletions tests/unit/operation/relateng/RelateNGTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -875,16 +875,5 @@ void object::test<62> ()
checkRelate(a, b, "212101212");
}

// Boundary node
// template<>
// template<>
// void object::test<63> ()
// {
// std::string a = "POLYGON((0 0,140 0,140 140,0 140,0 0))";
// std::string b = "POLYGON((140 0,0 0,0 140,140 140,140 0))";
// checkRelateRule(a, b, "2FFF0FFF2", geos::algorithm::BoundaryNodeRule::getBoundaryMultivalentEndPoint());
// }



} // namespace tut
9 changes: 2 additions & 7 deletions tests/unit/operation/relateng/RelateNGTest.h
Original file line number Diff line number Diff line change
Expand Up @@ -95,13 +95,13 @@ struct test_relateng_support {
checkPredicate(*RelatePredicate::equalsTopo(), wktb, wkta, expectedValue);
}

void checkRelateRule(const std::string& wkta, const std::string& wktb, const std::string expectedValue, const BoundaryNodeRule& bnRule)
void checkRelate(const std::string& wkta, const std::string& wktb, const std::string expectedValue)
{
std::unique_ptr<Geometry> a = r.read(wkta);
std::unique_ptr<Geometry> b = r.read(wktb);
RelateMatrixPredicate pred;
// TopologyPredicate predTrace = trace(pred);
RelateNG::relate(a.get(), b.get(), pred, bnRule);
RelateNG::relate(a.get(), b.get(), pred);
std::string actualVal = pred.getIM()->toString();
if (actualVal != expectedValue) {
std::cerr << std::endl << w.write(*a) << " relate " << w.write(*b) << " = " << actualVal << std::endl;
Expand All @@ -110,11 +110,6 @@ struct test_relateng_support {
checkPrepared(a.get(), b.get());
}

void checkRelate(const std::string& wkta, const std::string& wktb, const std::string expectedValue)
{
checkRelateRule(wkta, wktb, expectedValue, BoundaryNodeRule::getBoundaryRuleMod2());
}

void checkRelateMatches(const std::string& wkta, const std::string& wktb, const std::string pattern, bool expectedValue)
{
auto pred = RelatePredicate::matches(pattern);
Expand Down

0 comments on commit adc3348

Please sign in to comment.