Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce garbage produced every update #38

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Reduce garbage produced every update #38

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6c8eed0
reduce the garbage produced every update
klianc09 Jun 24, 2023
114d6a5
use IntFloatMap provided by libgdx instead of running a custom solution
klianc09 Jun 24, 2023
8072235
add comment to explain why these constants were introduced
klianc09 Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions ...desktop/src/main/java/com/badlogic/gdx/controllers/desktop/support/JamepadController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import com.badlogic.gdx.controllers.ControllerListener;
import com.badlogic.gdx.controllers.ControllerMapping;
import com.badlogic.gdx.controllers.ControllerPowerLevel;
import com.badlogic.gdx.utils.IntFloatMap;
import com.badlogic.gdx.utils.IntMap;
import com.badlogic.gdx.utils.Logger;
import com.badlogic.gdx.utils.TimeUtils;
Expand All @@ -18,20 +19,23 @@ public class JamepadController implements Controller {
private static final IntMap<ControllerButton> CODE_TO_BUTTON = new IntMap<>(ControllerButton.values().length);
private static final IntMap<ControllerAxis> CODE_TO_AXIS = new IntMap<>(ControllerAxis.values().length);
private static final Logger logger = new Logger(JamepadController.class.getSimpleName());
// ControllerButton.values() and ControllerAxis.values() is cached once, to avoid producing garbage every frame
private static final ControllerButton[] CONTROLLER_BUTTON_VALUES = ControllerButton.values();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment why this is done so people only reading the code know there were performance issues

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good idea, can do!

private static final ControllerAxis[] CONTROLLER_AXIS_VALUES = ControllerAxis.values();

static {
for (ControllerButton button : ControllerButton.values()) {
for (ControllerButton button : CONTROLLER_BUTTON_VALUES) {
CODE_TO_BUTTON.put(button.ordinal(), button);
}

for (ControllerAxis axis : ControllerAxis.values()) {
for (ControllerAxis axis : CONTROLLER_AXIS_VALUES) {
CODE_TO_AXIS.put(axis.ordinal(), axis);
}
}

private final CompositeControllerListener compositeControllerListener = new CompositeControllerListener();
private final IntMap<Boolean> buttonState = new IntMap<>();
private final IntMap<Float> axisState = new IntMap<>();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Libgdx has IntFloatMap which you can use to achieve this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, that's what I was looking for. Thx!

private final IntFloatMap axisState = new IntFloatMap();
private final String uuid;
private final String name;
private ControllerIndex controllerIndex;
Expand Down Expand Up @@ -128,11 +132,11 @@ private ControllerAxis toAxis(int axisCode) {
}

private void updateAxisState() {
for (ControllerAxis axis : ControllerAxis.values()) {
for (ControllerAxis axis : CONTROLLER_AXIS_VALUES) {
int id = axis.ordinal();

float value = getAxis(id);
if (value != axisState.get(id)) {
if (value != axisState.get(id, 0)) {
if (logger.getLevel() == Logger.DEBUG) {
logger.debug("Axis [" + id + " - " + toAxis(id) + "] moved [" + value + "]");
}
Expand All @@ -143,7 +147,7 @@ private void updateAxisState() {
}

private void updateButtonsState() {
for (ControllerButton button : ControllerButton.values()) {
for (ControllerButton button : CONTROLLER_BUTTON_VALUES) {
int id = button.ordinal();

boolean pressed = getButton(id);
Expand All @@ -163,11 +167,11 @@ private void updateButtonsState() {
}

private void initializeState() {
for (ControllerAxis axis : ControllerAxis.values()) {
axisState.put(axis.ordinal(), 0.0f);
for (ControllerAxis axis : CONTROLLER_AXIS_VALUES) {
axisState.put(axis.ordinal(), 0);
}

for (ControllerButton button : ControllerButton.values()) {
for (ControllerButton button : CONTROLLER_BUTTON_VALUES) {
buttonState.put(button.ordinal(), false);
}
}
Expand Down