BLOCKCHAIN-463 - Judiciary Phase 1 #388
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kacperzuk-neti
force-pushed
the
BLOCKCHAIN-463/judiciary-phase-1
branch
3 times, most recently
from
8a0d625
to
8dd2b2b
Compare
kacperzuk-neti
commented
Jun 20, 2024
| }, | ||
| }; | ||
| let transfer_to = match to { | ||
| LLMAccount::Liquid(account) => account, |
There was a problem hiding this comment.
This means that Courts are able to instantly unlock staked LLM. Is that OK or do we want only staked -> staked moves?
kacperzuk-neti
force-pushed
the
BLOCKCHAIN-463/judiciary-phase-1
branch
5 times, most recently
from
ef6c3d9
to
d05db42
Compare
kacperzuk-neti
commented
Jun 25, 2024
| #[derive(Default)] | ||
| pub struct LiberlandExtension; | ||
|
|
||
| impl LiberlandExtension { |
There was a problem hiding this comment.
Turns out we could do phase 1 with no chain extension using call_runtime. However:
- I found this after this chain extension was written 🤷
- it can only dispatch calls, not read any data. And we will need to read data in the future (asset balances, llm politipool). So enough for phase 1, but not for later.
kacperzuk-neti
force-pushed
the
BLOCKCHAIN-463/judiciary-phase-1
branch
from
7234ccc
to
c8068f7
Compare
Draft
kacperzuk-neti
force-pushed
the
BLOCKCHAIN-463/judiciary-phase-1
branch
from
c8068f7
to
7e7c27c
Compare
kacperzuk-neti
commented
Jul 8, 2024
| #[cfg_attr(feature = "std", derive(ink::storage::traits::StorageLayout))] | ||
| pub enum Proposal { | ||
| LLMForceTransfer(LLMForceTransferArguments), | ||
| SetGovernance { threshold: u32, judges: Vec<AccountId> }, |
There was a problem hiding this comment.
There's no such thing as sudo/root for contracts. So instead, adding/removing judges can be made by current judges, just like any other proposal.
If that's not OK and we want sudo, we can add a contract owner, set it to some address with no private key then use sudo.sudoAs to trigger it. Let me know what you prefer and I'll adjust if needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Process from merging to forcing move of some staked llm on real chain:
proposewithProposal::LLMForceTranfer {...}on the contractapprove