Stop using JSON spec files in runtime #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current binaries embed the JSON from
specs/bastiat.raw.jsonandspecs/mainnet.raw.jsonduring build and allow using--chain bastiatand--chain mainnetwithout having to use separate JSON file.Let's stop publishing separate JSON files and make install.sh rely on embedded specs.
Rationale: this will greatly simplify the upgrade process for users in case of chain spec changes (new bootnodes, new telemetry server, recovering chain in case of catastrophic failure) - they'll be able to just drop-in new binary and things will just work.
Compatibility:
install.shscript won't detect existing json-spec-based installations - users will be prompted to select the network (bastiat/mainnet) again when running script to update from json-spec to embedded-spec.