Skip to content

Use websocket_closed for detection of client stop, comments. #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evoskuil merged 1 commit into from
May 16, 2026
Merged

Use websocket_closed for detection of client stop, comments. #808

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions src/net/proxy.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,14 +52,10 @@ void proxy::stop(const code& ec) NOEXCEPT
if (stopped())
return;

// Client or timer initated stop is async (graceful).
// error::channel_stopped is send in various contexts, however the only
// ones in which the channel is not stopped are those arising directly from
// socket read handlers, resulting in a stop(ec) call. This is interpreted
// as client socket cancellation, which along with timer cancellations are
// allowed to close gracefully. error::service_stopped will invoke socket
// stop() below, which will immediately terminate outstanding lazy_stop().
if (ec == error::channel_stopped ||
// Client websocket or timer initated (when ws) stop is async (graceful).
// error::service_stopped will invoke socket stop() below, which will
// immediately terminate outstanding lazy_stop().
if (ec == error::websocket_closed ||
ec == error::channel_expired ||
ec == error::channel_inactive)
{
Expand Down
Loading