Skip to content

Remove misplaced assertion in populate_with_metadata(input). #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evoskuil merged 1 commit into from
May 8, 2026
Merged

Remove misplaced assertion in populate_with_metadata(input). #788

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions include/bitcoin/database/impl/query/consensus/consensus_populate.ipp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,9 @@ bool CLASS::populate_with_metadata(const input& input,
// Null point would return nullptr and be interpreted as missing.
BC_ASSERT(!input.point().is_null());

// input.metadata.point_link must be defaulted to max_uint32.
BC_ASSERT(input.metadata.point_link == max_uint32);
// If read via the store for store confirmation, then...
// input.metadata.point_link is set earlier in get_input().
////BC_ASSERT(input.metadata.point_link == max_uint32);

if (input.prevout)
return true;
Expand Down Expand Up @@ -132,9 +133,6 @@ bool CLASS::populate_with_metadata(const input& input,
}
}

// If read via the store for store confirmation, then...
// input.metadata.point_link must be set earlier in get_input().
////BC_ASSERT(input.metadata.point_link != max_uint32);
return !is_null(input.prevout);
}

Expand Down
Loading