Skip to content

fix: display actual schema file name in Schema tab #3752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: display actual schema file name in Schema tab #3752

wants to merge 1 commit into from
+20 −54

Conversation

devin-ai-integration[bot]
Copy link
Contributor

Issue

  • Resolves: route06/liam-internal#5778

Why is this change needed?

The Schema tab was displaying a hardcoded schema file name ("schema1.in.rb") instead of the actual linked schema file name from the database. Additionally, the issue requested removing the "ERD" tab navigation since there's only one tab.

Summary of Changes

  • Modified SchemaPage to fetch schema file information from database and extract the filename for display
  • Updated SchemaHeader to accept schemaName and format props instead of using hardcoded values
  • Removed TabsList UI since there's only one tab, simplifying the interface
  • Cleaned up unused code including SCHEMA_TABS constant and related CSS classes

⚠️ Critical Issues Requiring Review

🚨 RUNTIME ERROR: Missing Import

  • The code calls path.basename() but the path module is not imported in SchemaPage.tsx
  • This will cause an immediate runtime error and needs to be fixed before merge

Review Checklist

  • Fix missing path import in SchemaPage.tsx
  • Test functionality: Verify actual schema filenames are displayed correctly
  • Database efficiency: Consider if the duplicate query to schema_file_paths can be avoided (same query exists in getERDEditorContent)
  • Error handling: Add error handling for the new database query
  • UI verification: Confirm that removing tab navigation is the desired behavior
  • Edge cases: Test with missing schema files, malformed paths, etc.

Link to Devin Run

https://app.devin.ai/sessions/7f9b8efaefa34ffd825682d5482c625e

Requested by @MH4GF

@devin-ai-integration @MH4GF
fix: display actual schema file name in Schema tab
794886f 
- Pass schemaFilePath and format from SchemaPage to SchemaHeader
- Extract filename using path.basename for display
- Remove TabsList from SchemaHeader since there's only one tab
- Remove unused SCHEMA_TABS constant and CSS classes

Fixes route06/liam-internal#5778

Co-Authored-By: [email protected] <[email protected]>
@devin-ai-integration Devin.ai Integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@giselles-ai giselles.ai
Copy link

giselles-ai bot commented Oct 10, 2025 •
edited
Loading

Unexpected error on running flow

Step Status Updated(UTC)
1 ✅ Oct 10, 2025 11:31am
2 ✅ Oct 10, 2025 11:32am
3 ❌ Oct 10, 2025 11:32am

@vercel Vercel
Copy link

vercel bot commented Oct 10, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
liam-app Ready Ready Preview Comment Oct 10, 2025 11:37am
liam-assets Ready Ready Preview Comment Oct 10, 2025 11:37am
liam-storybook Ready Ready Preview Comment Oct 10, 2025 11:37am
2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
liam-docs Ignored Ignored Oct 10, 2025 11:37am
liam-erd-sample Skipped Skipped Oct 10, 2025 11:37am

@supabase Supabase
Copy link

supabase bot commented Oct 10, 2025 •
edited
Loading

Updates to Preview Branch (devin/1760095832-fix-schema-tab-display) ↗︎

Deployments Status Updated
Database ✅ Fri, 10 Oct 2025 11:34:36 UTC
Services ✅ Fri, 10 Oct 2025 11:34:36 UTC
APIs ✅ Fri, 10 Oct 2025 11:34:36 UTC

Tasks are run on every commit but only new migration files are pushed.
Close and reopen this PR if you want to apply changes from existing seed or migration files.

Tasks Status Updated
Configurations ✅ Fri, 10 Oct 2025 11:34:43 UTC
Migrations ✅ Fri, 10 Oct 2025 11:34:49 UTC
Seeding ✅ Fri, 10 Oct 2025 11:34:50 UTC
Edge Functions ✅ Fri, 10 Oct 2025 11:34:50 UTC

View logs for this Workflow Run ↗︎.
Learn more about Supabase for Git ↗︎.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 10, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Comment @coderabbitai help to get the list of available commands and usage tips.

@giselles-ai giselles.ai
Copy link

giselles-ai bot commented Oct 10, 2025

Check changeset necessity

Status:

  • NOT REQUIRED

Reason:

  • All edits are within the app codebase (@liam-hq/app), which is on the ignored packages list.
  • No changes were made to target packages that require changesets: @liam-hq/cli, @liam-hq/erd-core, @liam-hq/schema, or @liam-hq/ui.
  • Removal of TabsList/TabsTrigger affects only their usage in the app; there are no modifications to @liam-hq/ui itself.
  • User-facing behavior changes (displaying actual schema filename, removing tab UI) are confined to the ignored app package and do not impact published packages/APIs.

Changeset (copy & paste):

# Not required — this PR only changes @liam-hq/app (ignored package)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@MH4GF MH4GF

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@MH4GF