-
Notifications
You must be signed in to change notification settings - Fork 175
docs: Add testing guidance to CLAUDE.md #3749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Reference test-principles.md for test writing guidelines. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Unexpected error on running flow
|
Updates to Preview Branch (chore-claude-md-6) ↗︎
Tasks are run on every commit but only new migration files are pushed.
View logs for this Workflow Run ↗︎. |
WalkthroughAdds a Testing subsection to CLAUDE.md under CSS/Testing guidance, directing readers to follow principles in docs/test-principles.md. No code or control flow changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Check changeset necessityStatus: NOT REQUIRED Reason:
Changeset (copy & paste):N/A – docs-only change; do not create a changeset. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
CLAUDE.md (1)
114-117
: Add a Markdown link alongside the @ reference- - Follow principles in @docs/test-principles.md + - Follow principles in @docs/test-principles.md ([Testing principles](docs/test-principles.md))
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
CLAUDE.md
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: _e2e-tests (Mobile Safari)
- GitHub Check: security-review
- GitHub Check: Supabase Preview
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds testing guidance to the CLAUDE.md documentation file to ensure Claude Code follows established testing principles when writing tests.
- Added a new Testing section that references the established test principles documentation
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Issue
Why is this change needed?
Add reference to test-principles.md in CLAUDE.md to ensure Claude Code follows established testing principles when writing tests.
Summary
Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit