Skip to content

Conversation

NoritakaIkeda
Copy link
Member

@NoritakaIkeda NoritakaIkeda commented Oct 9, 2025

Issue

  • resolve: N/A (Documentation addition)

Why is this change needed?

This PR adds a comprehensive requirements definition document for the /projects/new page to improve project documentation and provide clear specification for the GitHub repository import functionality.

The document focuses on:

  • Business requirements and user perspective
  • Functional and non-functional requirements
  • User flows and acceptance criteria
  • Success metrics

This will help team members understand the purpose, scope, and expected behavior of the project creation feature without diving into implementation details.

Summary by CodeRabbit

  • Documentation
    • Added a comprehensive specification for the Project Creation page, covering goals, target users, functional and non-functional requirements, user flows (authenticated and GitHub App not installed), error handling, UI layout, data needs, integrations, constraints, extensibility, success criteria, acceptance criteria, and UI text states.
    • Improves clarity and alignment for implementation and testing of the page.
    • No user-facing behavior changes in this release.

Add comprehensive requirements definition document for the project creation page that handles GitHub repository imports.

Key sections:
- Purpose and target users
- Functional requirements (authentication, GitHub App installation, repository import)
- Non-functional requirements (performance, security, usability)
- User flows (standard, alternative, error scenarios)
- Screen layout and data requirements
- Constraints and future extensibility
- Success criteria

This document focuses on business requirements and user perspective rather than implementation details.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
Copy link

changeset-bot bot commented Oct 9, 2025

⚠️ No Changeset found

Latest commit: a9d7f4a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

giselles-ai bot commented Oct 9, 2025

Finished running flow.

Step Status Updated(UTC)
1 Oct 9, 2025 7:13am
2 Oct 9, 2025 7:13am
3 Oct 9, 2025 7:13am

Copy link

vercel bot commented Oct 9, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
liam-app Ready Ready Preview Comment Oct 9, 2025 7:18am
liam-assets Ready Ready Preview Comment Oct 9, 2025 7:18am
liam-erd-sample Ready Ready Preview Comment Oct 9, 2025 7:18am
liam-storybook Ready Ready Preview Comment Oct 9, 2025 7:18am
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
liam-docs Ignored Ignored Preview Oct 9, 2025 7:18am

Copy link

supabase bot commented Oct 9, 2025

Updates to Preview Branch (docs/add-projects-new-requirements) ↗︎

Deployments Status Updated
Database Thu, 09 Oct 2025 07:16:24 UTC
Services Thu, 09 Oct 2025 07:16:24 UTC
APIs Thu, 09 Oct 2025 07:16:24 UTC

Tasks are run on every commit but only new migration files are pushed.
Close and reopen this PR if you want to apply changes from existing seed or migration files.

Tasks Status Updated
Configurations Thu, 09 Oct 2025 07:16:29 UTC
Migrations Thu, 09 Oct 2025 07:16:33 UTC
Seeding Thu, 09 Oct 2025 07:16:35 UTC
Edge Functions Thu, 09 Oct 2025 07:16:35 UTC

View logs for this Workflow Run ↗︎.
Learn more about Supabase for Git ↗︎.

Copy link
Contributor

coderabbitai bot commented Oct 9, 2025

Walkthrough

Adds a new documentation specification file describing requirements, flows, and criteria for a “Project Creation” page, including authentication, GitHub App installation, repository selection, import process, error handling, non-functional requirements, integrations, constraints, and success metrics. No source code or API changes.

Changes

Cohort / File(s) Summary
Documentation — Project Creation Spec
docs/specifications/projects-new-page.md
New spec outlining goals, users, functional/non-functional requirements, user flows (authenticated and GitHub App not installed), UI states, error handling, data needs, integrations, constraints, extensibility, and acceptance criteria. No code changes.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor U as User
  participant W as Web App
  participant GH as GitHub App

  U->>W: Open "Create Project" page
  alt Not authenticated
    W-->>U: Redirect to Sign-in
    U->>W: Complete authentication
  end

  alt GitHub App not installed
    W-->>U: Prompt to install GitHub App
    U->>GH: Install/Authorize app
    GH-->>W: Installation callback
  end

  W->>GH: Fetch installations and repos
  GH-->>W: Return repo list
  W-->>U: Display selectable repositories

  U->>W: Select repo(s) and submit import
  W->>GH: Request repo access and metadata
  GH-->>W: Repo details and permissions
  W-->>U: Show import progress/status
  note over W,U: Handle errors (auth, permission, rate limits)
  W-->>U: Confirm project creation completion
Loading

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

I thump my paws—specs neatly aligned,
A warren of flows, requirements defined.
Repos like carrots, picked from a list,
Auth at the gate, no detail missed.
With gentle hops to import and done—
This project page is ready to run! 🥕✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title clearly summarizes the main change by stating that a requirements document for the /projects/new page is being added, accurately reflecting the PR’s purpose.
Description Check ✅ Passed The pull request description follows the required template by providing both the “## Issue” section with a resolve entry and the “## Why is this change needed?” section with a clear rationale, satisfying all mandatory fields.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch docs/add-projects-new-requirements

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

giselles-ai bot commented Oct 9, 2025

Check changeset necessity

Status: NOT REQUIRED

Reason:

  • The PR adds a documentation file only: docs/specifications/projects-new-page.md.
  • No changes to targeted publishable packages: @liam-hq/cli, @liam-hq/erd-core, @liam-hq/schema, or @liam-hq/ui.
  • The changes are non–user-facing (documentation only), which the guide exempts from needing a changeset.
  • Even if a docs package were involved, @liam-hq/docs is listed in the ignore set.

Changeset (copy & paste):

# No changeset required — documentation-only change touching no publishable packages.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0d93a70 and a9d7f4a.

📒 Files selected for processing (1)
  • docs/specifications/projects-new-page.md (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Supabase Preview
  • GitHub Check: security-review

Comment on lines +75 to +80
- 各リポジトリに"Import"ボタンが表示される
- ボタンクリックでプロジェクト作成処理が開始される
- 処理中はボタンが無効化され、"Importing..."と表示される
- 作成成功後、自動的に作成されたプロジェクトページへ遷移する
- 作成失敗時、エラーメッセージがコンソールに出力される

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Surface project import failures to users.

Acceptance criteria only require console logging on failure, leaving the user without in-product feedback and conflicting with NFR-003’s usability goal. Add a visible error state or toast so users understand the failure and recovery options.

🤖 Prompt for AI Agents
docs/specifications/projects-new-page.md around lines 75 to 80: Acceptance
currently only logs import failures to the console; change the spec to require
visible in-app error feedback (e.g., toast or inline error state) when project
import fails. Update the flow to (1) show a dismissible error toast or inline
error message with a clear failure reason and a suggested recovery action (retry
or contact support), (2) re-enable the Import button after failure so the user
can retry, and (3) still log the detailed error to console/telemetry for
debugging; adjust acceptance criteria and UI states to reflect these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant