fix build on macOS #100
Merged
fix build on macOS #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Shieldine can you elaborate, why C++20 is needed for macOS? hwinfo builds with C++11 on Windows and Linux... Or is it just that the used standard must be set? |
|
@lfreist it's just that a standard must be set or macOS will take something below 11 and thus fail to build. |
|
Thank you! Yes, please set it to 11 then. The plan is, that the first release is C++11 and later releases introduce more modern features. I want to make sure that a working version is available for C++11 compilers... |
|
@lfreist Way ahead of you! :) C++11 already passed the pipeline, ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the failing build on macOS. It seems to have been caused by removing the explicit setting of a cpp standard in the main CMakeLists.txt
It's now set to 20 as it was in previous commits