Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix terrible type converting, close #342 #343

Merged
merged 5 commits into from
Jul 7, 2024
Merged

fix terrible type converting, close #342 #343

merged 5 commits into from
Jul 7, 2024

Conversation

qishipai
Copy link
Contributor

@qishipai qishipai commented Jul 5, 2024 •
edited by perklet
Loading

修复 Curl.setopt() 对 curl_off_t 类型的支持

Close #342

@qishipai
Update curl.py
ede2780 
fix terrible type converting
@qishipai
Update shim.c
31439bc 
fix terrible type converting
@qishipai
Update curl.py
ad63e35
perklet
perklet requested changes Jul 6, 2024
View reviewed changes
Copy link
Collaborator

@perklet perklet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, this part is indeed some quick and dirty code added at the beginning of this project and not carefully designed.

ffi/shim.c Outdated Show resolved Hide resolved
ffi/shim.c Outdated Show resolved Hide resolved
@perklet perklet changed the title fix terrible type converting fix terrible type converting, close #342 Jul 6, 2024
@qishipai qishipai requested a review from perklet July 6, 2024 08:09
@perklet perklet merged commit 630a4dc into lexiforest:main Jul 7, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perklet perklet Awaiting requested review from perklet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Curl.setopt() 中糟糕的类型传递
2 participants
@qishipai @perklet