Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create sub snapshot folder if needed #46

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

marc-neumann
Copy link
Contributor

Hi,

With the change in PR #41 the possibility to create any sub snapshot folder was removed.

See commit https://github.com/levinmr/rspec-snapshot/pull/41/files#diff-77a31662fea6835344c608536c400f703b46bab2949428eb582dc07538ee2752R29

This PR added the possibility again.

@marc-neumann
Copy link
Contributor Author

any news about this PR.
When can it be merged?

@martinechtner
Copy link

@levinmr +1 for this functionality. Currently we have to manually create the directory structure first and then run the spec. We changed the default snapshot_dir to another location so a directory structure is needed. Related to issue #45

@levinmr levinmr closed this Apr 2, 2024
@levinmr levinmr reopened this Apr 2, 2024
@levinmr levinmr closed this Apr 2, 2024
@levinmr levinmr reopened this Apr 2, 2024
@levinmr
Copy link
Owner

levinmr commented Apr 2, 2024

Apologies for the spam if you're getting notifications about this PR opening and closing. Trying to get the status checks to run

@levinmr levinmr merged commit 366fee0 into levinmr:master Apr 2, 2024
10 checks passed
@levinmr
Copy link
Owner

levinmr commented Apr 2, 2024

Thanks for the PR. I have released a new gem version with this change included: https://github.com/levinmr/rspec-snapshot/releases/tag/v2.0.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants