Undo background thread execution #1
Conversation
There was a problem hiding this comment.
@SandishKumarHN thank you for preparing a commit against my branch.
| @@ -918,41 +909,10 @@ private void scheduleWriteTouch(final long bufferWatermarkOffsetInFile, final lo | |||
| // If we really have to cancel write touch tasks, it means that the logging rate is so high that | |||
There was a problem hiding this comment.
The containing method, scheduleWriteTouch() should be removed completely. Generally, the new version of the class shouldn't even mention "touch", "pretouch". All related methods should be removed.
| @@ -496,13 +496,6 @@ private void doCloseAndSwitchRegionExclusively() { | |||
| // it's return it is guaranteed that all concurrent writers has completed. | |||
| if (manager.closing) { | |||
There was a problem hiding this comment.
unmapMappedBuffer() shouldn't be wrapped in if (manager.closing). Try to understand why the code with background execution used to have this if (manager.closing) condition. When you understand it, you'll realize why if (manager.closing) is not needed without background threading.
| @@ -972,15 +932,10 @@ private void drainWriteTouchTasks() { | |||
| } | |||
|
|
|||
| private void asyncCreateNextRegion(final Region currentRegion, final long newMappingOffsetInFile) { | |||
There was a problem hiding this comment.
This method is no longer "async". You cannot just rename it to "createNextRegion" because there is already a method with this name. So I think this method should be now inlined at its sole usage site.
There was a problem hiding this comment.
I Will name it as syncCreateNextRegion for now.
|
@leventov below are the charts hosted on Github pages |
|
|
Also, did you benchmark log4j master back then, or the current master? |
Undo background thread execution