Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Commit

Permalink
chore(app): remove scan tabs to keep development lean
Browse files Browse the repository at this point in the history
  • Loading branch information
fuxingloh committed Jul 6, 2023
1 parent 5f863ae commit d82880f
Show file tree
Hide file tree
Showing 7 changed files with 9 additions and 67 deletions.
1 change: 0 additions & 1 deletion app/app/_layout.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ function AppContainer(): JSX.Element | null {
<Stack.Screen name="about/licenses" options={{ presentation: 'modal' }} />
<Stack.Screen name="api/settings" options={{ presentation: 'modal' }} />
<Stack.Screen name="keys/settings" options={{ presentation: 'modal' }} />
<Stack.Screen name="scan/settings" options={{ presentation: 'modal' }} />
</Stack>
</ExternalLinkProvider>
</HapticFeedbackProvider>
Expand Down
34 changes: 0 additions & 34 deletions app/app/scan/settings.tsx

This file was deleted.

7 changes: 4 additions & 3 deletions app/app/tabs/_layout.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,10 @@ export default function TabsLayout(): JSX.Element {
headerTitleStyle: tailwind('text-white'),
}}
>
<Tabs.Screen {...tabScreenProps({ route: 'index', title: 'Keys', icon: 'key' })} />
<Tabs.Screen {...tabScreenProps({ route: 'api', title: 'API', icon: 'API' })} />
<Tabs.Screen {...tabScreenProps({ route: 'scan', title: 'Scan', icon: 'scan1' })} />
<Tabs.Screen {...tabScreenProps({ route: 'index', title: 'Keychain', icon: 'key' })} />
<Tabs.Screen {...tabScreenProps({ route: 'api', title: 'API Requests', icon: 'API' })} />
{/* TODO(fuxingloh): implement scan. It is a planned feature, but removed it first to keep the development lean. */}
{/* <Tabs.Screen {...tabScreenProps({ route: 'scan', title: 'Scan', icon: 'scan1' })} /> */}
<Tabs.Screen {...tabScreenProps({ route: 'settings', title: 'Settings', icon: 'setting' })} />
</Tabs>
);
Expand Down
6 changes: 2 additions & 4 deletions app/app/tabs/api.tsx
Original file line number Diff line number Diff line change
@@ -1,15 +1,13 @@
import { Stack } from 'expo-router';
import { Text, View } from 'react-native';
import { useTailwind } from 'tailwind-rn';

export default function ApiPage(): JSX.Element {
export default function ApiTab(): JSX.Element {
const tailwind = useTailwind();

return (
<>
<Stack.Screen options={{ title: 'API' }} />
<View style={tailwind('flex-1 items-center justify-center bg-zinc-900')}>
<Text style={tailwind('text-center text-xl text-white')}>API</Text>
<Text style={tailwind('text-center text-xl text-white')}>API Requests</Text>
</View>
</>
);
Expand Down
4 changes: 2 additions & 2 deletions app/app/tabs/index.tsx
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
import { Text, View } from 'react-native';
import { useTailwind } from 'tailwind-rn';

export default function KeysPage(): JSX.Element {
export default function KeychainTab(): JSX.Element {
const tailwind = useTailwind();
return (
<>
<View style={tailwind('flex-1 flex-col items-center justify-center bg-zinc-900')}>
<Text style={tailwind('text-center text-xl text-white')}>Keys</Text>
<Text style={tailwind('text-center text-xl text-white')}>Keychain</Text>
</View>
</>
);
Expand Down
14 changes: 0 additions & 14 deletions app/app/tabs/scan.tsx

This file was deleted.

10 changes: 1 addition & 9 deletions app/app/tabs/settings.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { useExternalLink } from '../ExternalLinkProvider';
import { useHaptic } from '../HapticFeedback';
import { IconSet } from '../IconSet';

export default function SettingPage(): JSX.Element {
export default function SettingsTab(): JSX.Element {
const tailwind = useTailwind();

return (
Expand Down Expand Up @@ -39,14 +39,6 @@ export default function SettingPage(): JSX.Element {
title: 'API Settings',
},
},
{
type: 'select',
props: {
to: '/scan/settings',
icon: 'scan1',
title: 'Scan Settings',
},
},
],
},
{
Expand Down

0 comments on commit d82880f

Please sign in to comment.