va: normalize caa parameter tags to lowercase#8616
va: normalize caa parameter tags to lowercase#86161seal wants to merge 3 commits intoletsencrypt:mainfrom
Conversation
rfc 8659 specifies that property tags (issue/issuewild) are processed case-insensitively. this change extends the same treatment to parameter tag names (accounturi, validationmethods), so that mixed-case tags like AccountURI= are matched correctly rather than silently ignored.
add regression tests covering accounturi and validationmethods parameters with mixed-case tag names, for both issue and issuewild records.
|
two questions:
|
No, this does not rise to the level of something warranting notice, this has not affected anyone, and site operators are not generally aware of the Boulder source repository and release process.
See my comment on the initial bug; we'd actually like to take this a different direction. |
|
pushed an update implementing the "fail-closed" direction:
commit: e125976 |
fixes #8614.
this normalizes caa parameter tag names to lowercase during parsing, so mixed-case forms like
AccountURI=andValidationMethods=are enforced the same way as the lowercase forms.adds regression coverage in
va/caa_test.gofor mixed-caseaccounturiandvalidationmethods(includingissuewild).