Skip to content

Introduce nonfunctional IssuerConfig.Profiles config field #8423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2025
Merged

Introduce nonfunctional IssuerConfig.Profiles config field #8423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions issuance/issuer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,11 @@ type IssuerConfig struct {
// The selection of which pool depends on the precertificate's key algorithm.
Active bool

// Profiles is the list of profiles for which this issuer is willing to issue.
// For the moment, this does nothing, and exists only for deployability.
// TODO(#8390): Make this field required for active issuers.
Profiles []string `validate:"omitempty,dive,alphanum,min=1,max=32"`

IssuerURL string `validate:"required,url"`
CRLURLBase string `validate:"required,url,startswith=http://,endswith=/"`

Expand Down
16 changes: 16 additions & 0 deletions test/config-next/ca.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,9 @@
"issuers": [
{
"active": true,
"profiles": [
"legacy"
],
"crlShards": 10,
"issuerURL": "http://ca.example.org:4502/int-ecdsa-a",
"crlURLBase": "http://ca.example.org:4501/lets-encrypt-crls/43104258997432926/",
Expand All @@ -111,6 +114,11 @@
},
{
"active": true,
"profiles": [
"legacy",
"modern",
"shortlived"
],
"crlShards": 10,
"issuerURL": "http://ca.example.org:4502/int-ecdsa-b",
"crlURLBase": "http://ca.example.org:4501/lets-encrypt-crls/17302365692836921/",
Expand All @@ -133,6 +141,9 @@
},
{
"active": true,
"profiles": [
"legacy"
],
"crlShards": 10,
"issuerURL": "http://ca.example.org:4502/int-rsa-a",
"crlURLBase": "http://ca.example.org:4501/lets-encrypt-crls/29947985078257530/",
Expand All @@ -144,6 +155,11 @@
},
{
"active": true,
"profiles": [
"legacy",
"modern",
"shortlived"
],
"crlShards": 10,
"issuerURL": "http://ca.example.org:4502/int-rsa-b",
"crlURLBase": "http://ca.example.org:4501/lets-encrypt-crls/6762885421992935/",
Expand Down