Skip to content

Conversation

aarongable
Copy link
Contributor

@aarongable aarongable commented Sep 26, 2025

Change how the CA determines which issuer to use (the pickIssuer helper), to take into account the requested profile, alongside the CSR's key algorithm. This simple loop allows us to greatly simplify how the CA has to track its set of issuers, resulting in some wider-reaching changes to the NewCertificateAuthorityImpl constructor, the unit tests, and boulder-ca/main.go.

Fixes #8390


Note

TODO:

  • Write TestPickIssuer
  • Fix TestIssueCertificate_UnpredictableIssuance to not access the (now deleted) ca.issuers.byAlg

Warning

Do not merge before #8424
Do not merge before #8423 has been deployed
Do not merge before IN-11840 has been completed

Copy link
Contributor

@jsha jsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good! Some small comments.

@aarongable aarongable force-pushed the use-issuer-profiles branch from fb42e7f to a1e2343 Compare October 2, 2025 00:43
@aarongable aarongable changed the base branch from main to ca-refactor October 2, 2025 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants