Skip to content

grpc: Enable client-side health_v1 health checking #8254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 18, 2025
Merged

grpc: Enable client-side health_v1 health checking #8254

merged 7 commits into from
Jun 18, 2025

Conversation

beautifulentropy
Copy link
Member

@beautifulentropy beautifulentropy commented Jun 16, 2025 •
edited
Loading

  • Configure all gRPC clients to check the overall serving status of each endpoint via the grpc_health_v1 service.
  • Configure all gRPC servers to expose the grpc_health_v1 service to any client permitted to access one of the server’s services.
  • Modify long-running, deep health checks to set and transition the overall (empty string) health status of the gRPC server in addition to the specific service they were configured for.

Fixes #8227

@beautifulentropy beautifulentropy mentioned this pull request Jun 16, 2025
Open
@beautifulentropy beautifulentropy force-pushed the grpc-client-health branch 2 times, most recently from 495d54f to 9c668a6 Compare June 16, 2025 21:31
@beautifulentropy beautifulentropy marked this pull request as ready for review June 16, 2025 21:31
@beautifulentropy beautifulentropy requested a review from a team as a code owner June 16, 2025 21:31
@beautifulentropy
Copy link
Member Author

Apologies for the force push.

aarongable
aarongable reviewed Jun 16, 2025
View reviewed changes
@aarongable aarongable requested review from a team and jprenken and removed request for a team June 16, 2025 23:26
jprenken
jprenken previously approved these changes Jun 16, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

@beautifulentropy, this PR appears to contain configuration and/or SQL schema changes. Please ensure that a corresponding deployment ticket has been filed with the new values.

@beautifulentropy
Copy link
Member Author

@beautifulentropy, this PR appears to contain configuration and/or SQL schema changes. Please ensure that a corresponding deployment ticket has been filed with the new values.

None of these changes necessitate a corresponding change by SRE before deployment. The removal of service specific checks is being tracked in IN-11451.

aarongable
aarongable reviewed Jun 17, 2025
View reviewed changes
aarongable
aarongable reviewed Jun 17, 2025
View reviewed changes
@beautifulentropy
Copy link
Member Author

beautifulentropy commented Jun 17, 2025 •
edited
Loading

I have pushed the Consul changes to #8261 because a CI flake just occurred in: https://github.com/letsencrypt/boulder/actions/runs/15716828209/job/44288499469

We'll need to work on having startservers.py actually check whether endpoints are up before beginning tests.

@beautifulentropy beautifulentropy merged commit 1bfc318 into main Jun 18, 2025
12 checks passed
@beautifulentropy beautifulentropy deleted the grpc-client-health branch June 18, 2025 14:37
aarongable pushed a commit to aarongable/boulder that referenced this pull request Jun 18, 2025
@beautifulentropy @aarongable
grpc: Enable client-side health_v1 health checking (letsencrypt#8254)
6a19287 
- Configure all gRPC clients to check the overall serving status of each
endpoint via the `grpc_health_v1` service.
- Configure all gRPC servers to expose the `grpc_health_v1` service to
any client permitted to access one of the server’s services.
- Modify long-running, deep health checks to set and transition the
overall (empty string) health status of the gRPC server in addition to
the specific service they were configured for.

Fixes letsencrypt#8227

(cherry picked from commit 1bfc318)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aarongable aarongable aarongable approved these changes

@jprenken jprenken jprenken approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix our grpc_health_v1 implementation

3 participants

@beautifulentropy @aarongable @jprenken