[P130] Add simple circuit to get a current sensor , result is Irms #4009

handfreezer · 2022-04-18T08:02:07Z

Note: to get real current value (not Irms), you just have to use the formulas " %value% * 1.414 ".
It is working at home from more than 4 months now, here is an example of result:
(As you can see, we can also observe my holidays...)

…er 1V, not a success

…er, using ADS1015 to sample the wave and calculate current through Irms method (around 60 sample over 20ms, you can select how many wave you want to get accurate measure ;-) )

…ository

Centralised default reading conf of ADS1015

(sample count are similar between 2400 and 3300 => ESP32 too slow to benefit of 3300 BUT 2400 is more accurate!)

Update README.md

TD-er · 2022-04-18T08:16:05Z

src/src/PluginStructs/P130_data_struct.cpp

+    } else {
+        String log = F("Irms - ADS1015 : writeRegister NOK, errcode= ");
+        log += res ;
+        addLog(LOG_LEVEL_INFO, log);


Looks like an error, thus use LOG_LEVEL_ERROR.

TD-er · 2022-04-18T08:16:47Z

src/src/PluginStructs/P130_data_struct.cpp

+    res = Wire.endTransmission();
+    if ( 0 == res ) {
+        result = true;
+    } else {


Make this

} else { if (logLevelActiveFor(LOG_LEVEL_ERROR)) { ... } result = false; }

See also next comment about log level.

TD-er · 2022-04-18T08:22:58Z

src/src/PluginStructs/P130_data_struct.cpp

+    return result;
+}
+
+boolean P130_data_struct::readRegister(uint8_t registerAddr, uint16_t& registerValue) {


Please use I2C_read16_reg in ESPEasy/src/src/Helpers/I2C_access.h instead of re-implementing those I2C functions. (same for writeRegister above)

Thing is, there is lots and lots of I2C code doing it wrong (e.g. calling Wire.endTransmission() after Wire.requestForm()) and when you're using a single function like the one I linked, I know it is correct and if it isn't, I only need to fix it at one place.

TD-er · 2022-04-18T08:25:31Z

src/src/PluginStructs/P130_data_struct.cpp

+            currentValue = voltage * calCurrent;
+        }
+        if (false != this->debug) {
+            String log;


Please wrap logs like these in

#ifndef BUILD_NO_DEBUG #endif

so the builds meant for as small builds as possible will not have debug code in them.

Also always wrap logs that need string manipulation in checks like if (logLevelActiveFor(LOG_LEVEL_XXXX)) {

tonhuisman · 2022-04-18T11:28:32Z

README.md

@@ -1,3 +1,6 @@
+# ⚠️ This is a fork of [letscontrolit/ESPEasy](https://github.com/letscontrolit/ESPEasy) and you should prefer to start from original project! This fork is for personnal maintenance and making PR to original project. ⚠️


I don't think this should go into the official ESPEasy repository... please remove this from this PR (you can of course keep it in your fork)

tonhuisman · 2022-04-18T11:34:35Z

docs/source/Plugin/P130.rst

+This is where you specify the calibration of the current sensor you connected, say you have connected a current sensor given for 50A/1V, you will indicate 50.
+
+* **Canal 1 - Max current** : Current value for 1V
+* **Canal 2 - Max current** : Current value for 1V


Canal is most likely French, in English this should be Channel, ditto in _P130_IRMS_ADS1015.ino (and you probably need to update the screenshots too)

tonhuisman · 2022-04-18T11:37:50Z

src/Custom-sample.h

@@ -392,7 +392,9 @@ static const char DATA_ESPEASY_DEFAULT_MIN_CSS[] PROGMEM = {
 // #define USES_P125   // ADXL345 SPI Acceleration / Gravity
 // #define USES_P126   // 74HC595 Shift register
 // #define USES_P127   // CDM7160
-
+// #define USES_P128   //
+// #define USES_P129   //


P128 and P129 will define their own here, no need to fill the gap, and it will probably cause minor merge issues

tonhuisman · 2022-04-18T11:41:23Z

src/_P130_IRMS_ADS1015.ino

+
+#define PLUGIN_130
+#define PLUGIN_ID_130 130
+#define PLUGIN_NAME_130 "Current Sensor Irms - ADS1015"


To have plugin names with the same structure, this should probably be Current - ADS1015 IRMS [TESTING] (or use Irms), and include the status of the plugin (either Development or Testing).

tonhuisman · 2022-04-18T11:43:27Z

src/_P130_IRMS_ADS1015.ino

+      addFormFloatNumberBox(F("Voltage Estimated"), F("p130_voltageEstimated"), PCONFIG_FLOAT(0), 0.0, 380.0, 2);
+      addFormSubHeader(F("Calibration"));
+      addFormNumericBox(F("Canal 1 - Max Current"), F("p130_calCurrent1"), PCONFIG(1), 1, 250);
+      addFormNumericBox(F("Canal 2 - Max Current"), F("p130_calCurrent2"), PCONFIG(2), 1, 250);


See above, Canal -> Channel

tonhuisman · 2022-04-18T11:46:13Z

src/_P130_IRMS_ADS1015.ino

+      addFormNumericBox(F("Current Frequency"), F("p130_frequency"), PCONFIG_LONG(0), 50, 60);
+      addFormNumericBox(F("Nb Sinus to read"), F("p130_nb_sinus"), PCONFIG_LONG(1), 1, 25);
+      addFormNote("Take care! Reading sinus is a blocking process. With a SCT013 (60A/50A/30A - 1V), reading 2 sinus on 50Hz giving stable values.");
+      addFormCheckBox(F("ADC Conversion Mode Continous"), F("p130_adc_continous"), PCONFIG_LONG(2));


To more reliably convert that to a bool, better use PCONFIG_LONG(2) == 1 here.

tonhuisman · 2022-04-18T11:47:09Z

src/_P130_IRMS_ADS1015.ino

+
+      PCONFIG_LONG(0) = getFormItemInt(F("p130_frequency"));
+      PCONFIG_LONG(1) = getFormItemInt(F("p130_nb_sinus"));
+      PCONFIG_LONG(2) = (true == isFormItemChecked(F("p130_adc_continous")))?1:0;


C/C++ treats a non-zero value as true, so no need to compare to true

tonhuisman · 2022-04-18T11:55:38Z

src/src/CustomBuild/define_plugin_sets.h

@@ -1192,6 +1191,7 @@ To create/register a plugin, you have to :
    #define USES_P121   // HMC5883L 
    #define USES_P125   // ADXL345 SPI
    #define USES_P126  // 74HC595 Shift register
+    #define USES_P130   // Current Sensor Irms - ADS1015


This plugin should IMHO better fit in the PLUGIN_ENERGY_COLLECTION selection, not in the PLUGIN_SET_TESTING_E set. (And when moving there, should be updated in the documentation too).

tonhuisman · 2022-04-18T11:58:46Z

src/src/CustomBuild/define_plugin_sets.h

@@ -1343,7 +1343,7 @@ To create/register a plugin, you have to :
 	//#define USES_P124	// Ventus_W266_RFM69
 	#define USES_P125	// ArduCAM
 	#define USES_P127	// Teleinfo
-	#define USES_P130	// VEML6075
+	#define USES_P130	// [Irms - ADS1015](https://github.com/letscontrolit/ESPEasy/issues/3839)


This is defining the Experimental set of plugins, AKA ESPEasyPluginPlayGround. No need to change anything here, as that uses a separate plugin-ID range. This set can probably be removed or at least trimmed, but that should become be a separate PR, and handled by someone else 😉.

tonhuisman · 2022-04-18T12:05:18Z

src/src/PluginStructs/P130_data_struct.cpp

+
+    // write conf+ =>start reading
+    if ( false == this->writeRegister(P130_ADS1X15_REG_POINTER_CONFIG, configStartContinuous) ) {
+        addLog(LOG_LEVEL_INFO, F("readadccontinuous write register conf failed"));


Another LOG_LEVEL_ERROR to log here?

handfreezer · 2022-05-15T11:49:16Z

Hello, I'm sorry for a so long silent from my side, I'm a quiet bit occupied, but I agree with almost.
I'll try to do changes on next weeks.

Ether and others added 17 commits February 6, 2022 12:11

First try of a plugin for reading current through ADS1015 + SCT013 ov…

c50f175

…er 1V, not a success

Successfull creation of plugin to get current from an alternative pow…

889b135

…er, using ADS1015 to sample the wave and calculate current through Irms method (around 60 sample over 20ms, you can select how many wave you want to get accurate measure ;-) )

Merge branch 'letscontrolit:mega' into mega

61835ce

Merge branch 'letscontrolit:mega' into mega

e4e5f38

Validation préparation du pull request en plugin 130 dans une branche

74232c3

Merge branch 'mega' of https://github.com/handfreezer/ESPEasy into mega

c7b6530

removing local P126 as failed POC

5f89618

Migrating plugin from local POC P127 to official P130

3119a25

Applying right way to get a personnal build without polluting git rep…

1135c89

…ository

Few rename and cleaning code/default values

26af21f

Changing default conversion rate to get a more stable value

6ffd1c1

Centralised default reading conf of ADS1015

rolling back to origin

89be65e

Adding possibility to select Sample Per Second between 1600/2400/3300

69e9877

(sample count are similar between 2400 and 3300 => ESP32 too slow to benefit of 3300 BUT 2400 is more accurate!)

Update README.md

e77eace

Adding documentation for P130 plugin Current Sensor through ADS1015

d192d93

Merge pull request #1 from handfreezer/mega

eddff51

Update README.md

Merge branch 'mega' into P130_01

5647d1f

handfreezer mentioned this pull request Apr 18, 2022

[Plugins] List of planned new plugins (request a Plugin-ID here) #3839

Open

Remove local testing profil

1a76556

TD-er requested changes Apr 18, 2022

View reviewed changes

tonhuisman reviewed Apr 18, 2022

View reviewed changes

TD-er and others added 3 commits November 21, 2022 23:40

Merge branch 'mega' into P130_01

afcf524

Merge branch 'letscontrolit:mega' into P130_01

6e2ecdb

Merge branch 'mega' into P130_01

f25c9da

tonhuisman mentioned this pull request Sep 1, 2023

ADS1115 value are 0.00 #4768

Closed

TD-er added 2 commits September 1, 2023 20:10

Merge branch 'mega' into P130_01

95e83cd

Merge branch 'mega' into P130_01

02a67dc

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[P130] Add simple circuit to get a current sensor , result is Irms #4009

[P130] Add simple circuit to get a current sensor , result is Irms #4009

handfreezer commented Apr 18, 2022

TD-er Apr 18, 2022

TD-er Apr 18, 2022

TD-er Apr 18, 2022

TD-er Apr 18, 2022

tonhuisman Apr 18, 2022

tonhuisman Apr 18, 2022

tonhuisman Apr 18, 2022

tonhuisman Apr 18, 2022

tonhuisman Apr 18, 2022

tonhuisman Apr 18, 2022

tonhuisman Apr 18, 2022

tonhuisman Apr 18, 2022

tonhuisman Apr 18, 2022

tonhuisman Apr 18, 2022

handfreezer commented May 15, 2022

		@@ -1,3 +1,6 @@
		# ⚠️ This is a fork of [letscontrolit/ESPEasy](https://github.com/letscontrolit/ESPEasy) and you should prefer to start from original project! This fork is for personnal maintenance and making PR to original project. ⚠️

[P130] Add simple circuit to get a current sensor , result is Irms #4009

Are you sure you want to change the base?

[P130] Add simple circuit to get a current sensor , result is Irms #4009

Conversation

handfreezer commented Apr 18, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

handfreezer commented May 15, 2022