Test Fix: Fix a test that can unintentionally fail in testAppName() #454
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The app_name environment variable is not being set in the Blade instance before running the test. This leads to a null result from the environment, which does not match the randomly generated string (anyString).
Below is an example where it fails under NonDex on line 95
Click on to see more details on the error message when running this test
To reproduce, run this at the root directory:
(Note: We are running the test 10 times using -DnondexRuns=10, and it should fail each time.)
The log output can be found here for your reference:
mvn-nondex-1729136764.log
To resolve this, we should set the environment variable ENV_KEY_APP_NAME before running the test.
After applying the fix, the test should now pass with NonDex as expected:
Please let me know if this approach works for you. If not, I'm happy to discuss alternatives and am willing to spend more time to address the test in the way you'd prefer. Thank you!