Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added test case for when a queue is passed to 'enqueue_in_with_queue' wh... #77

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nata79
Copy link

@nata79 nata79 commented Aug 28, 2013

I developed a proxy to abstract our code base from the background-processing library, which always calls the 'enqueue_in_with_queue' method.

The problem is that sometimes the queue name, it passes, is also defined inside the worker class (with an instance variable) and our specs are written like this "ResqueSpec.schedule_for(NameFromClassMethod).should_not be_empty". This causes our tests to break because the 'schedule_queue_name' always append '_scheduled' to the queue name. Removing this works fine for me and is not breaking any other test, so I suppose it's fine, since I also did not find any reference to it the resque_scheduler gem.

… which is the same as the one defined in the class

removed '_scheduled' keyword from queue names
@leshill
Copy link
Owner

leshill commented Sep 9, 2013

Hi @nata79,

Sorry about the delay in getting around to this.

Scheduler takes a job and stores it elsewhere, and then moves it to a queue when the schedule indicates. In resque_spec this is done by appending the _scheduled to the queue; i.e. the job is scheduled but not queued.

Is there something else that might work with your specs? When using ResqueSpec.schedule_for, wouldn't you want the _scheduled appended to check the scheduled jobs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants