Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fix token expiration check for proactive refreshing #634

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Fix: fix token expiration check for proactive refreshing #634

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3da1fdc
Fix token expiration check for proactive refreshing
princekhunt Mar 21, 2024
650748c
chnage the parameter to leeway
princekhunt Mar 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions authlib/oauth2/rfc6749/wrappers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,13 @@ def __init__(self, params):
int(params['expires_in'])
super().__init__(params)

def is_expired(self):
def is_expired(self, leeway=60):
expires_at = self.get('expires_at')
if not expires_at:
return None
return expires_at < time.time()
# small timedelta to consider token as expired before it actually expires
expiration_threshold = expires_at - leeway
return expiration_threshold < time.time()

@classmethod
def from_dict(cls, token):
Expand Down
Loading