Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker improvements #73

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kurthuwig
Copy link

No description provided.

Reduce image size by removing APT database as well as install packages
Fewer steps thus fewer intermediate containers
Use standard ENTRYPOINT instead of custom CMD
@lephisto
Copy link
Owner

I will test the changes later today, thanks for that PR

@baylanger
Copy link

Reporting from my installation from last night and it didn't go well because ....

This first commit below with title "Windows fix" breaks apiscraper to start, at least not with Python 3.5.

tkrajina/srtm.py@a7c2fa4

The next commit removes support for Python 3.5 and adding 3.7 & 3.8 to the list.

tkrajina/srtm.py@87f417e

It is sad srtm is dropping support for 3.5 so. " early ". The Debian image comes with Python 3.5 and based on the above commit, it seems 3.6+ would work.

The below steps installs 3.7 and I confirm this makes latest SRTM commits all happy .. since I'm not Docker pro, please double check the steps.

{noformat}
RUN echo 'deb http://ftp.de.debian.org/debian testing main' >> /etc/apt/sources.list &&
echo 'APT::Default-Release "stable";' >> /etc/apt/apt.conf.d/00local &&
cat /etc/apt/sources.list &&
cat /etc/apt/apt.conf.d/00local

RUN apt-get update
&& DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends -t testing
python3.7
python3-distutils
python3-pip
&& rm -rf /var/lib/apt/lists/ /var/cache/apt/*
{noformat}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants