fix validity check to avoid no sleep condition, fixes #46 #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lephisto
approved these changes
May 2, 2019
|
Will merge this evening.. |
zpan45
approved these changes
Jun 4, 2019
ffllc
approved these changes
Sep 13, 2019
|
Issue 46 says "merged" but this PR is still open, any reason? I'm new and soon planning to install under docker w/ NAS. For that I plan to merge all PR into my branch and will report back. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also ran into the no sleep condition reported in #46, and adding the validity check at the top of the loop over elements seems to fix the issue.