Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get PyPI install from source working #221

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

raphaelshirley
Copy link
Member

By including a manifest file we can hopefully ensure that the pybind source is recursively cloned and shipped which will allow pypi to build from source when binaries are not available

Closes #217 #220

It is still unclear to me whether compiler and the required libraries will also be installed as required.

  • My PR includes a link to the issue that I am addressing

Solution Description

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Project-Specific Pull Request Checklists

Bug Fix Checklist

  • My fix includes a new test that breaks as a result of the bug (if possible)
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

New Feature Checklist

  • I have added or updated the docstrings associated with my feature using the NumPy docstring format
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover my new feature
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

Documentation Change Checklist

Build/CI Change Checklist

  • If required or optional dependencies have changed (including version numbers), I have updated the README to reflect this
  • If this is a new CI setup, I have added the associated badge to the README

Other Change Checklist

  • Any new or updated docstrings use the NumPy docstring format.
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover any changes
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

By including a manifest file we can hopefully ensure that the pybind source is recursively cloned and shipped
which will allow pypi to build from source when binaries are not available
Previously the cpp code coverage was failing due to an error. I added an
ignore error command to lcov but as Johann suggested this may have been a glitch as
later a new error arose saying the ignore errors command did not work it seems
the version of lcov installed changed perhaps as a result of others having similar bugs so
I removed the ignore error command
@raphaelshirley raphaelshirley changed the title Added MANIFEST.in file Get PyPI install from source working Oct 17, 2024
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.61%. Comparing base (8adf41f) to head (b57ed26).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #221      +/-   ##
==========================================
+ Coverage   66.40%   66.61%   +0.20%     
==========================================
  Files          50       50              
  Lines        6225     6221       -4     
  Branches      941      937       -4     
==========================================
+ Hits         4134     4144      +10     
+ Misses       2091     2077      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@johannct johannct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@raphaelshirley raphaelshirley merged commit 0c42828 into main Oct 17, 2024
14 checks passed
@raphaelshirley raphaelshirley deleted the issue/220/allow-pypi-build-from-source branch October 17, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow PyPI to build from source
2 participants