Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(oralce):separate prepareRound from endBlock into beginBlock #2

Closed
wants to merge 1 commit into from

Conversation

leonz789
Copy link
Owner

@leonz789 leonz789 commented Jul 4, 2024

Description


Closes #XXX

func (am AppModule) BeginBlock(_ sdk.Context, _ abci.RequestBeginBlock) {}
func (am AppModule) BeginBlock(ctx sdk.Context, _ abci.RequestBeginBlock) {
_ = keeper.GetCaches()
agc := keeper.GetAggregatorContext(ctx, am.keeper)

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods Warning

path flow from Begin/EndBlock to a panic call
@leonz789 leonz789 closed this Jul 4, 2024
cloud8little added a commit that referenced this pull request Jul 8, 2024
* Update goreleaser.yml (#2)

* fix(ci): upgrade deprecated goreleaser

- Set version in `.goreleaser.yml`
- Correct the `goreleaser-cross` version to use the latest available and
  compatible version
- Update workflow to test release builds on pull requests, but not
  publish them

---------

Co-authored-by: cloud8little <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant