Named parameters: A test with a syntax error in the signature #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t/op/signatures.t (t096_named): A syntax error with named parameters A very similar test with positional parameters is in t096, I *guess* the same error message should appear for named parameters
leonerd
force-pushed
the
signature-named-parameters
branch
3 times, most recently
from
dcdbe8c to
52ccfb0
Compare
leonerd
force-pushed
the
signature-named-parameters
branch
6 times, most recently
from
a009c2c to
83373f0
Compare
leonerd
force-pushed
the
signature-named-parameters
branch
from
83373f0 to
7d0b61a
Compare
leonerd
force-pushed
the
signature-named-parameters
branch
2 times, most recently
from
922a8c8 to
eda3ef8
Compare
|
A useful cornercase to test. I've added this and a fix for it to my branch. |
leonerd
force-pushed
the
signature-named-parameters
branch
9 times, most recently
from
e0d65bb to
7676a6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am very much interested in named parameters and only yesterday
started a new project... which will now use the signature-named-parameters branch, because of why not.
One of my first quick attempts hit a weird way where it goes wrong.
This signature lacks a comma between the parameters:
Running it through the Perl interpreter which understands named parameter segfaults.
I found equivalent tests for positional parameters in t/op/signatures.t. Maybe the different path to parse named parameters should get its own test?
The error message in the test is just a guess and might need adjustment...