Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RegularGrid, Convolution, some util functions #25

Merged
merged 14 commits into from
Nov 13, 2024

Conversation

ahuang314
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.73%. Comparing base (cc5b303) to head (6498b90).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
+ Coverage   99.72%   99.73%   +0.01%     
==========================================
  Files          34       37       +3     
  Lines        2910     3068     +158     
==========================================
+ Hits         2902     3060     +158     
  Misses          8        8              
Files with missing lines Coverage Δ
jaxtronomy/ImSim/Numerics/convolution.py 100.00% <100.00%> (ø)
jaxtronomy/ImSim/Numerics/grid.py 100.00% <100.00%> (ø)
jaxtronomy/Util/image_util.py 100.00% <100.00%> (ø)
jaxtronomy/Util/util.py 100.00% <100.00%> (ø)

@ahuang314
Copy link
Collaborator Author

@sibirrer What's going on with the pre-commit bot here?

@sibirrer
Copy link
Contributor

@ahuang314 something is broken with the pre-commit. You can ignore it in the meantime and focus on the CI and code coverage

@ahuang314 ahuang314 changed the title RegularGrid implementation using jnp arrays + a few util functions RegularGrid implementation using jnp arrays + one util function Oct 17, 2024
@ahuang314 ahuang314 changed the title RegularGrid implementation using jnp arrays + one util function RegularGrid, Convolution, some util functions Nov 13, 2024
Copy link
Contributor

@sibirrer sibirrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you @ahuang314 !

@ahuang314 ahuang314 merged commit a9eff67 into lenstronomy:main Nov 13, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants