Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: No Sentry alert on 500 error from the app #588

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

taorepoara
Copy link
Member

@taorepoara taorepoara commented Sep 4, 2024

About this PR

Closes #560

When the app returns an 500 error on manifest, view or listener, it creates a Sentry alert.

This behavior is fixed since we don't want Sentry alert is this case.

How to test my changes

Run the unit tests.

Checklist

  • I didn't over-scope my PR
  • My PR title matches the commit convention
  • I did not include breaking changes
  • I made my own code-review before requesting one

I included unit tests that cover my changes

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

I added/updated the documentation about my changes

  • 📜 README.md
  • 📕 docs/*.md
  • 📓 docs.lenra.io
  • 🙅 no documentation needed

@taorepoara taorepoara self-assigned this Sep 4, 2024
@taorepoara taorepoara marked this pull request as ready for review September 4, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Some app's errors are treated as server errors
1 participant