Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this PR
Closes #562
Technical highlight/advice
There was an issue with the Kubernetes.Status GenServer that could not be stopped because it did not exist.
The stop method is called directly from Kubernetes with the CALLBACK_URL that is passed as a secret.
So Kubernetes calls the
runner/build/:id
API endpoint to update the build status. The server updates the status which is good and expected behaviour, it then tries to stop the Kubernetes.Status GenServer because it is not needed anymore. I don't really know why but this GenServer does not exist when the error occurs and it crashes the server.We just want to ignore the error when the GenServer does not exist because it means that we do not need to stop it as it is already stopped.
How to test my changes
I don't know how you can test my changes easily because you need to setup a kubernetes cluster on your computer.
Checklist
I included unit tests that cover my changes
I added/updated the documentation about my changes