Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Manage defining a custom OAuth Helper #17

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

taorepoara
Copy link
Member

@taorepoara taorepoara commented Dec 29, 2023

About this PR

The user might need to use a custom OAuth helper to have advanced customization.

Checklist

  • I didn't over-scope my PR
  • My PR title matches the commit convention
  • I did not include breaking changes
  • I made my own code-review before requesting one

I included unit tests that cover my changes

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

I added/updated the documentation about my changes

  • 📜 README.md
  • 📕 docs/*.md
  • 📓 docs.lenra.io
  • 🙅 no documentation needed

@taorepoara taorepoara added the enhancement New feature or request label Dec 29, 2023
@taorepoara taorepoara marked this pull request as ready for review December 29, 2023 16:41
Copy link
Contributor

@jonas-martinez jonas-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonas-martinez jonas-martinez merged commit ce853b9 into main Dec 29, 2023
7 checks passed
@jonas-martinez jonas-martinez deleted the custom-oauthhelper branch December 29, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants