-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ✨ Links to openfeedbacks #24
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gouz for this PR.
You're right, the icons could be bigger and we can give them a look of a button.
For the unit tests, you can check that every session in the camping-data.js
file has a openfeedback link.
You also should add the openfeedback link in the session pages.
Co-authored-by: Thomas DA ROCHA <[email protected]>
Co-authored-by: Thomas DA ROCHA <[email protected]>
All done ;) Thanks for the advices |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems OK. Thanks again !
This PR also made me think that I forgot to add the favorite button in the session page ^^
Closes #22
Description des modifications
Add links to OpenFeedBack website on each session to allow a vote and give feedbacks to the author.
Liste de contrôle
J'ai inclus des tests unitaires qui couvrent mes modifications
J'ai ajouté/mis à jour la documentation concernant mes modifications
Point technique/remarque
I think we can improve the a11y with bigger icons and a look like buttons