remove all state from the llamacpp backend#801
Merged
jeremyfowers merged 3 commits intolemonade-sdk:mainfrom Jan 9, 2026
Merged
remove all state from the llamacpp backend#801jeremyfowers merged 3 commits intolemonade-sdk:mainfrom
jeremyfowers merged 3 commits intolemonade-sdk:mainfrom
Conversation
jeremyfowers
reviewed
Jan 9, 2026
Member
|
Ran into some odd behavior. Going to wait for #804 to merge so that I can be sure I'm not confusing myself. |
jeremyfowers
approved these changes
Jan 9, 2026
Member
jeremyfowers
left a comment
jeremyfowers
left a comment
There was a problem hiding this comment.
Tested locally. Logging is improved and there are no functional regressions (including multi-model).
jeremyfowers
removed this pull request from the merge queue due to the queue being cleared
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #790
Closes #822
removes all class variables from
llamacpp_server.cpp. This helps in keeping track of how the arguments are handled, avoids outdated state. This also fixes logs showing outdated state and possibly outdateduse_gpustate.LEMONADE_LLAMACPP_BACKENDhas been removed as non-functional.LEMONADE_LLAMACPPalready exists and is working, soLEMONADE_LLAMACPP_BACKENDwas probably a leftover