Upload video to wandb #84
Open
+27
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mayankm96
reviewed
May 9, 2025
| if self.logger_type == "wandb" and not self.disable_logs: | ||
| # use video_fps from cfg if available or default to 30 | ||
| if "video_fps" in self.cfg: | ||
| video_fps = self.cfg["video_fps"] |
There was a problem hiding this comment.
shouldn't this be something from the environment and not the agent cfg?
This was referenced May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uploads videos in the log directory to wandb.
Added a method to
WandbSummaryWriterto check for .mp4 in log directory and upload them to wandb. This method is triggered inside thelogmethod of runner.I understand there is another PR in works addressing this, I was working on this for a project anyway.
Please share your feedback, thank you for your time.