Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature refine RPC & pan sharpen #15

Merged
merged 93 commits into from
Sep 7, 2024
Merged

Feature refine RPC & pan sharpen #15

merged 93 commits into from
Sep 7, 2024

Conversation

dugalh
Copy link
Collaborator

@dugalh dugalh commented Sep 7, 2024

Features:

  • Add RPC model refinement with GCPs.
  • Add Gram-Schmidt pan sharpening.
  • Round and clip image data when necessary, before writing to file.
  • Refactor utils module to common.
  • Copy RGB* source colour profile to output image.
  • Tighten parameter file validation and improve error handling in CLI & thread pools.

Fixes:

  • Change duplicated short form CLI options.
  • Improve downsampling of test images.

Docs:

  • Re-organise the CLI getting started section.
  • Add docs for RPC refinement, pan sharpening and GCP file formats.

Tests:

  • Add and update tests & data for RPC refinement and pan sharpening.

dugalh added 30 commits July 24, 2024 17:10
- simplify progress bars
- share common configuration
- allow pan & MS index arguments
- validate indexes with weights
- redo auto weights without -ve bands
- fix convert_array_dtype() clip for int array dtype
- force CRS georeferencing
- class-wide working dtype to avoid conversions
- shutdown thread pools on exception
- auto-weights revert to original if re-solving doesn't help
- docstring and comment updates
- add dtype, nodata & num_threads to VRT profiles
- use nodata to find VRT masks
- progress bar includes overviews
Copy link

codecov bot commented Sep 7, 2024

Codecov Report

Attention: Patch coverage is 90.81365% with 70 lines in your changes missing coverage. Please review.

Project coverage is 93.05%. Comparing base (1c06df6) to head (821395e).
Report is 94 commits behind head on main.

Files with missing lines Patch % Lines
orthority/param_io.py 81.14% 33 Missing ⚠️
orthority/pan_sharp.py 95.07% 13 Missing ⚠️
orthority/fit.py 85.71% 7 Missing ⚠️
orthority/factory.py 82.75% 5 Missing ⚠️
orthority/camera.py 60.00% 4 Missing ⚠️
orthority/ortho.py 90.62% 3 Missing ⚠️
orthority/cli.py 97.89% 2 Missing ⚠️
orthority/common.py 97.77% 2 Missing ⚠️
orthority/enums.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
- Coverage   93.83%   93.05%   -0.79%     
==========================================
  Files          11       13       +2     
  Lines        2205     2734     +529     
==========================================
+ Hits         2069     2544     +475     
- Misses        136      190      +54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dugalh dugalh merged commit 5b4bfcf into main Sep 7, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant