Skip to content

Commit

Permalink
remove completed to dos
Browse files Browse the repository at this point in the history
  • Loading branch information
dugalh committed Oct 14, 2023
1 parent c000e23 commit b953aa5
Show file tree
Hide file tree
Showing 5 changed files with 2 additions and 8 deletions.
2 changes: 1 addition & 1 deletion simple_ortho/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
import pathlib

# enable on-demand download and caching of proj transformation grids
os.environ.update(PROJ_NETWORK='ON', PROJ_ONLY_BEST_DEFAULT='ON')
os.environ.update(PROJ_NETWORK='ON')

# path to package root TODO: remove with deprecated simple-ortho CLI
if '__file__' in globals():
Expand Down
1 change: 1 addition & 0 deletions simple_ortho/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -769,3 +769,4 @@ def parse_args(argv=None):
cli()

# TODO: test CLI exceptions are meaningful
# TODO: add radians option for CSV files
1 change: 0 additions & 1 deletion simple_ortho/io.py
Original file line number Diff line number Diff line change
Expand Up @@ -938,7 +938,6 @@ def write_int_param(
raise FileExistsError(f"Interior parameter file exists: '{filename}'.")
filename.unlink()

# TODO: just use cam_type in oty format?
# convert 'cam_type' key to 'type' & make the converted item the first in the dict
yaml_dict = {}
for cam_id, int_param in int_param_dict.items():
Expand Down
1 change: 0 additions & 1 deletion simple_ortho/ortho.py
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,6 @@ def _mask_dem(
Crop and mask the given DEM to the ortho polygon bounds, returning the adjusted DEM and corresponding
transform.
"""
# TODO: trace rays in a thread pool?
def inv_transform(transform: rio.Affine, xy: np.array):
""" Return the center (j, i) pixel coords for the given transform and world (x, y) coordinates. """
return np.array(~(transform * rio.Affine.translation(0.5, 0.5)) * xy)
Expand Down
5 changes: 0 additions & 5 deletions tests/test_io.py
Original file line number Diff line number Diff line change
Expand Up @@ -608,8 +608,3 @@ def test_oty_reader_crs(ngi_oty_ext_param_file: Path, ngi_crs: str):
""" Test OtyReader reads the crs correctly. """
reader = io.OtyReader(ngi_oty_ext_param_file, crs=None)
assert reader.crs == rio.CRS.from_string(ngi_crs)


# TODO: radians in CSV
# - perhaps add second fixture that rewrites e.g. ngi_xyz_opk.csv in radians (perhaps a parameterised fixture),
# then a test that reads both radians and degrees files and compares results. could do same for odm_lla_rpy.csv.

0 comments on commit b953aa5

Please sign in to comment.