JS Port #18
Merged
JS Port #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
October 17, 2016 12:40
'Hello world' Node application using Express & EJS
Using validator to check for a valid URL, and the github node package to query the GitHub API.
CSS link was type="test/css" as opposed to "text/css"
"Check out the high score chart for your GitHub repo! http://gitscore.herokuapp.com" Closes #3
Now includes personalised link for the high scores page. Footer link still refers to the website itself.
Changed .right to .fl-right, for clarity with .left (changed to .align-left)
'Hello world' Node application using Express & EJS
Using validator to check for a valid URL, and the github node package to query the GitHub API.
CSS link was type="test/css" as opposed to "text/css"
added 26 commits
October 17, 2016 18:06
"Check out the high score chart for your GitHub repo! http://gitscore.herokuapp.com" Closes #3
Now includes personalised link for the high scores page. Footer link still refers to the website itself.
Changed .right to .fl-right, for clarity with .left (changed to .align-left)
user.handlebars now takes an object containing an array of users, as opposed to taking a single user and being called multiple times.
Actually closes #1
|
(for #17) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated example running on GitHub Pages here.
Re-written using Node.js, Browserify & Handlebars.js.
Also using validator, tape (for testing) and the GitHub API.
There are a couple of differences from my original Express.js effort:
example.com/?user/repoAnd a couple of things to do, if this is merged:
Let me know if you've got any more feedback. It was good fun to work on!
Cheers 🎃