Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add example configuration for data list #406

Merged
merged 1 commit into from
Jul 6, 2024
Merged

Add example configuration for data list #406

merged 1 commit into from
Jul 6, 2024

Conversation

jemayn
Copy link
Contributor

@jemayn jemayn commented Jul 1, 2024

Came across a TODO for missing documentation when trying to set up a data picker. Figured I'd PR an example that works for me 🙂

Types of changes

  • Documentation change
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the coding style of this project.
  • My changes generate no new warnings.
  • My change requires a change to the documentation.
  • I have updated the corresponding documentation.
  • I have read the CONTRIBUTING and CODE_OF_CONDUCT documents.

@jemayn jemayn requested a review from leekelleher as a code owner July 1, 2024 14:05
@leekelleher leekelleher self-assigned this Jul 1, 2024
leekelleher
leekelleher approved these changes Jul 6, 2024
View reviewed changes
Copy link
Owner

@leekelleher leekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, thank you @jemayn! 🙏

@leekelleher leekelleher merged commit 77de461 into leekelleher:develop Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leekelleher leekelleher leekelleher approved these changes

Assignees

@leekelleher leekelleher

Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jemayn @leekelleher