Fix ledger/vim-ledger issue #163 by disabling further option processing #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocessing before passing the entry.
alerque
reviewed
Dec 4, 2024
| @@ -674,7 +674,7 @@ endf | |||
| " Use current line as input to ledger entry and replace with output. If there | |||
| " are errors, they are echoed instead. | |||
| function! ledger#entry() abort | |||
| let l:output = split(system(s:ledger_cmd(g:ledger_main, join(['entry', getline('.')]))), '\n') | |||
| let l:output = split(system(s:ledger_cmd(g:ledger_main, join(['--', 'entry', getline('.')]))), '\n') | |||
There was a problem hiding this comment.
Shouldn't the entry subcommand go on the other side of (prior to) the argument separator?
There was a problem hiding this comment.
If you prefer I can change it. entry being a command is not an option so putting -- before it to end option processing is still correct.
I can imagine there being a user somewhere that might be using this current behavior to pass custom options to ledger when running entry and either version of the fix would break their workflow. Otherwise putting the -- before or after entry has the same effect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #163.