Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue#178 refactor subplugins calls #189

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tuanngocnguyen
Copy link

Hi @NinaHerrmann

Regards #178, I have made changes for the external trigger/step plugins.
All existing builtin plugins should still works as they are.
This patch allow developers to define additional lifecycle trigger/step plugins outside their pre-defined subplugins folders.
That is, a tool_sampletrigger can be defined as a lifecycle trigger if it define a trigger class (subclass of \tool_lifecycle\trigger\base) under "tool_sampletrigger\lifecycle" name space.

Please let me know your opinion on this.
Thanks

@jwcatau
Copy link

jwcatau commented Oct 16, 2023

Hallo @NinaHerrmann!

Just touching base with you regarding @tuanngocnguyen's subplugin refactor PR.

We're building this for a client who are happy to contribute this and additional sub-plugins which depend on this architecture, which poses a (small) risk in the event that your plugin needs to be forked.

If you'd like, I'd be keen to touch base with you on this to discuss the adjusted plugin approach, with a view to confirming the changes we're proposing to your plugin are satisfactory, and likely to be accepted.

This will greatly assist with version management and open up your plugin for more plugins (some of which are under development by us) can be published using the same architecture.

Kind regards,
James.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants