fix error when otherindex does not exist

learnweb · Dec 6, 2023 · daf05d5 · daf05d5
1 parent ddb70d8
commit daf05d5
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/classes/local/manager/workflow_manager.php b/classes/local/manager/workflow_manager.php
@@ -328,12 +328,14 @@ public static function change_sortindex($workflowid, $up) {
             array(
                 'sortindex' => $otherindex)
         );
-        $otherworkflow = workflow::from_record($otherrecord);
+        if (false !== $otherrecord) {
+            $otherworkflow = workflow::from_record($otherrecord);
+            $otherworkflow->sortindex = $index;
+            self::insert_or_update($otherworkflow);
+        }
 
         $workflow->sortindex = $otherindex;
-        $otherworkflow->sortindex = $index;
         self::insert_or_update($workflow);
-        self::insert_or_update($otherworkflow);
 
         $transaction->allow_commit();
     }