Run more locales w/ improved metadata #10
Conversation
|
|
||
| self.channel_name = BASE_TITLE # English to begin with | ||
| self.channel_source_id = BASE_SOURCE_ID | ||
| self.channel_domain = "https://phet.colorado.edu" |
There was a problem hiding this comment.
Why was this changed between the old code and the new code? (prepending https://)
There was a problem hiding this comment.
IIRC we'd already published some channels on Studio w/ that source_domain before Jamie pointed out that this is not consistent (or maybe I noticed it in the admin table after the fact)?
So - short answer: My mistake 😓 some of which is hard-coded to be handled around line 226.
constants.py
Outdated
| @@ -0,0 +1,7 @@ | |||
| HT_TITLE = 'PhET (Kreyòl ayisyen)' | |||
There was a problem hiding this comment.
Why are some here, and not in the CSV files?
There was a problem hiding this comment.
This whole file is unused - what is relevant from it was put directly into the chef.py file. I've removed the HT and EN descriptions, though, because they were just serving as a fallback.
However, the arabic one I kept as-is because there is no Arabic entry in the CSV file w/ the taglines and such so we're using this one in lieu of what we get from the API.
The latest CHANNEL_DESCRIPTIONS are directly in chef.py HT_TITLE not used at all
|
Found a few more things to clean-up thanks to your comments, thanks Richard |
2 participants
Summary
Runs all languages & includes metadata in CSV added by Radina and used during the cheffing process.
By default, all languages will run, but the
--lang=a,b,carg can be used to do a subset of locales.Fixes learningequality/kolibri-library#14
Fixes learningequality/kolibri-library#15