[Remove Vuetify from Studio] Saved searches dialogs #5604
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,72 +13,61 @@ | |
| /> | ||
| <p | ||
| v-else-if="savedSearches.length === 0" | ||
| class="empty-state" | ||
| > | ||
| {{ $tr('noSavedSearches') }} | ||
| </p> | ||
| <ul | ||
| v-else | ||
| class="saved-searches-list" | ||
| > | ||
| <li | ||
| v-for="(search, index) in savedSearches" | ||
| :key="search.id" | ||
| class="search-item" | ||
| > | ||
| <div class="search-content"> | ||
| <div class="search-title"> | ||
| <KRouterLink | ||
| :to="searchResultsRoute(search)" | ||
| class="notranslate saved-search-link" | ||
| @click="dialog = false" | ||
| > | ||
| {{ search.name }} | ||
| </KRouterLink> | ||
| </div> | ||
| <div class="metadata"> | ||
| <span> | ||
| {{ $formatRelative(search.created, { now: new Date() }) }} | ||
| </span> | ||
| <span> | ||
| {{ $tr('filterCount', { count: searchFilterCount(search) }) }} | ||
| </span> | ||
| </div> | ||
| </div> | ||
|
|
||
| <div class="search-actions"> | ||
| <IconButton | ||
| icon="clear" | ||
| color="grey" | ||
| :text="$tr('deleteAction')" | ||
| @click="handleClickDelete(search.id)" | ||
| /> | ||
| </div> | ||
| </li> | ||
| </ul> | ||
| </KModal> | ||
|
|
||
| <KModal | ||
| v-if="showDelete" | ||
| :title="$tr('deleteSearchTitle')" | ||
| :cancelText="$tr('cancelAction')" | ||
| :submitText="$tr('deleteAction')" | ||
| @cancel="handleCancel" | ||
| @submit="handleDeleteConfirm" | ||
| > | ||
| <p>{{ $tr('deleteConfirmation') }}</p> | ||
| </KModal> | ||
| </div> | ||
|
|
||
| </template> | ||
|
|
@@ -87,14 +76,12 @@ | |
| <script> | ||
| import { mapActions, mapGetters } from 'vuex'; | ||
| import IconButton from 'shared/views/IconButton'; | ||
| export default { | ||
| name: 'SavedSearchesModal', | ||
| inject: ['RouteNames'], | ||
| components: { | ||
| IconButton, | ||
| }, | ||
| props: { | ||
|
|
@@ -189,7 +176,44 @@ | |
|
|
||
| <style scoped lang="scss"> | ||
| .empty-state { | ||
| padding: 8px; | ||
|
Member
There was a problem hiding this comment. Would you remove this padding? I realize that you used it to preserve the original experience as requested - thanks for paying attention to that :) I just think that here it'd be more meaningful to rely on default |
||
| color: var(--v-grey-base); | ||
|
Member
There was a problem hiding this comment. |
||
| } | ||
| .saved-searches-list { | ||
| padding: 0; | ||
| margin: 0; | ||
| list-style: none; | ||
| } | ||
| .search-item { | ||
| display: flex; | ||
| align-items: center; | ||
| justify-content: space-between; | ||
| padding: 16px 0; | ||
| border-bottom: 1px solid rgba(0, 0, 0, 0.12); | ||
|
Member
There was a problem hiding this comment. |
||
| &:last-child { | ||
| border-bottom: none; | ||
| } | ||
| } | ||
| .search-content { | ||
| flex: 1; | ||
| min-width: 0; | ||
| } | ||
| .search-title { | ||
| margin-bottom: 4px; | ||
| } | ||
| .saved-search-link { | ||
| font-weight: 600; | ||
| } | ||
| .metadata { | ||
| font-size: 14px; | ||
| color: var(--v-grey-darken2); | ||
|
Member
There was a problem hiding this comment. https://design-system.learningequality.org/colors#tokens-annotation Same token will replace |
||
| span:not(:last-child)::after { | ||
|
|
@@ -199,4 +223,9 @@ | |
| } | ||
| } | ||
| .search-actions { | ||
| flex-shrink: 0; | ||
| margin-left: 16px; | ||
| } | ||
| </style> | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you please replace by
KIconButton? I think using the proxy component in this case doesn't have any additional impact (and later as part of migrating to KDS fully, we will removeIconButtonanyway)