Skip to content

Feedback utility functions #5088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 20 commits into
base: unstable
Choose a base branch
from

Conversation

akolson
Copy link
Member

@akolson akolson commented Jun 6, 2025

Summary

This pr does the following;

  • Implements the feedback UI you to collect feedback about search recommendations.
  • Adds events to track, added, rejected, previewed and ignored recommendations.
  • Implements bulk insertion of events for post requests
  • creates a new action(attraction) around the feedbackUtils to manage the feedback capture better

image

Screenshot 2025-06-17 at 10 28 40 Screenshot 2025-06-17 at 10 28 52

References

Fixes #5057
Fixes #5058
Fixes #5088

Reviewer guidance

  • import from other channels
  • Interact with recommendations
  • Feedback should be submitted correctly and there should be no regressions.
  • Ensure that recommendations are stored in successfully. You may need to shell into the models to determine that storage is happening in the RecommendationsEvent and RecommendationsInteractionEvent models

ozer550
ozer550 previously requested changes Jun 9, 2025
Copy link
Member

@ozer550 ozer550 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logically, everything in the code makes sense! Just a few small tweaks and some debugging is needed to resolve the UI issues encountered during testing. Additionally, I have a few thoughts on potential optimizations we could explore further.

@akolson akolson requested review from ozer550 and bjester June 13, 2025 07:56
@akolson akolson force-pushed the feedback-utility-functions branch from a8759bb to 02b5952 Compare June 30, 2025 12:47
@akolson akolson changed the title Feedback utility functions [WIP] Feedback utility functions Jul 2, 2025
Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless I'm missing something, the event ordering seems misaligned.

Additionally, there's a confusing mix of async/await, old-style Promise chaining, and some ignored promises. I suggest some consistency, with code comments for explaining the purposes of any inconsistencies-- if a promise is ignored, give a reason. For new code, I see no reason not to use async/await

@bjester bjester assigned bjester and unassigned ozer550 Jul 11, 2025
@akolson akolson force-pushed the feedback-utility-functions branch from 5e48e3d to c793fc9 Compare July 14, 2025 23:55
@akolson akolson changed the title [WIP] Feedback utility functions Feedback utility functions Jul 14, 2025
@akolson akolson requested a review from bjester July 14, 2025 23:55
Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the updates to the code, @akolson! Nice work. Feels much cleaner and localized. Let's test it on the unstable server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants